From 11045c1ccd3452d8e21e0d896577033dafb3977d Mon Sep 17 00:00:00 2001 From: Avinash Kumar Deepak Date: Thu, 12 Feb 2026 14:14:18 +0530 Subject: [PATCH] check taskkill return code on Windows to detect failures --- concore_cli/commands/stop.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/concore_cli/commands/stop.py b/concore_cli/commands/stop.py index 0b2f530..5b0a9a9 100644 --- a/concore_cli/commands/stop.py +++ b/concore_cli/commands/stop.py @@ -56,9 +56,11 @@ def stop_all(console): name = proc.info.get('name', 'unknown') if sys.platform == 'win32': - subprocess.run(['taskkill', '/F', '/PID', str(pid)], - capture_output=True, - check=False) + result = subprocess.run(['taskkill', '/F', '/PID', str(pid)], + capture_output=True, + check=False) + if result.returncode != 0: + raise RuntimeError(f"taskkill failed with code {result.returncode}") else: proc.terminate() proc.wait(timeout=3)