Skip to content

import_concoredocker.m is a duplicate of import_concore.m with no Docker-specific behavior #285

@GaneshPatil7517

Description

@GaneshPatil7517

@pradeeban
Both import_concore.m and import_concoredocker.m are 43 lines and completely identical. They both contain the same path detection logic:

if exist('/in1','dir')==7
    concore.inpath = '/in';
    concore.outpath = '/out';
else
    concore.inpath = 'in';
    concore.outpath = 'out';
end

Additionally, both unconditionally create a concorekill.bat file (Windows-specific), even when running on Linux/macOS or inside Docker containers:

outputpid = fopen('concorekill.bat','w');
fprintf(outputpid,'%s',['taskkill /F /PID ',num2str(pid)]);

This creates a useless Windows batch file inside Docker containers (which run Linux). The Docker variant should skip the concorekill.bat generation entirely, and if both files are identical, one should be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions