Skip to content

chore: tighten Challenge 2 issue validation#214

Merged
accesswatch merged 1 commit into
mainfrom
chore/harden-learning-room-progression
May 18, 2026
Merged

chore: tighten Challenge 2 issue validation#214
accesswatch merged 1 commit into
mainfrom
chore/harden-learning-room-progression

Conversation

@accesswatch
Copy link
Copy Markdown
Collaborator

Summary\n- enforce Challenge 2 issue quality checks (specific title + What/Where/Why + docs/welcome.md + TODO reference)\n- post actionable revision feedback when required fields are missing\n- apply status labels: challenge-2-complete or challenge-2-needs-revision\n- update Challenge 2 issue template text in source and qa-bundle with explicit required format\n\n## Notes\n- This preserves current Challenge 2 workflow trigger behavior and only strengthens instruction adherence.

Copilot AI review requested due to automatic review settings May 18, 2026 01:29
@accesswatch accesswatch requested a review from taylorarndt as a code owner May 18, 2026 01:29
@accesswatch accesswatch merged commit bf3b615 into main May 18, 2026
8 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Hi! I am Gandalf, your workshop agent. I bring a little magic to make this interaction clear, helpful, and fun. Here is my review of your pull request:

Report Status

Validation Needs Attention [ACTION REQUIRED]

Required Checks

  • Issue Reference
    PR should reference the issue it addresses (e.g., "Closes #12")
    Add "Closes #XX" to your PR description to automatically close the issue when merged. Learn more: docs/04-working-with-issues.md

  • PR Description

  • File Location
    Changes should be in learning-room/ directory only
    Student contributions should modify files in learning-room/docs/ only. Other directories are workshop infrastructure.

Learning Resources

Based on your changes, these guides might help:


Automated validation by Learning Room Bot. Gandalf generated this review. Last updated: 2026-05-18T01:29:35.086Z
Questions? Check PR Guidelines or mention @Facilitator

@github-actions
Copy link
Copy Markdown
Contributor

Learning Room Validation Report

Great work. Your changes look good.

Resources

@github-actions github-actions Bot added documentation Improvements or additions to documentation needs-work labels May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Progress Update

Great work, @accesswatch!

Current Level: Explorer
Merged PRs: 26
Next Level: Contributor (NaN more merged PRs)

Available Challenges:

  • 01 Scavenger Hunt
  • 02 First Issue
  • 03 Join Conversation

Keep going!

@github-actions
Copy link
Copy Markdown
Contributor

Peer Review Assigned

Hi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review.

For @taylorarndt:

This is a great opportunity to practice code review skills! Here's what to look for:

Content Quality:

  • Does the change accomplish what the issue describes?
  • Is the writing clear and helpful?
  • Are there any typos or grammar issues?

Accessibility:

  • Proper heading hierarchy (H1 → H2 → H3, no skips)?
  • Descriptive link text (not "click here")?
  • Alt text on images?
  • [TODO] markers removed?

Documentation:

  • Code blocks are properly formatted?
  • Tables have headers?
  • References/links work correctly?

Review Guidelines:

  • Be kind and constructive
  • Suggest improvements, don't just point out problems
  • Ask questions if something is unclear
  • Approve when ready or request changes with explanation

Resources:


Pairing by Learning Room Grouping Engine

@accesswatch accesswatch review requested due to automatic review settings May 18, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant