Fix cli sluggishness by removing unnecessary re-renders

Author: jahooma

cli/src/chat.tsx

@@ -164,7 +164,7 @@ export const Chat = ({
     setSlashSelectedIndex,
     agentSelectedIndex,
     setAgentSelectedIndex,
-    streamingAgents,
+    streamingAgents: rawStreamingAgents,
     focusedAgentId,
     setFocusedAgentId,
     messages,
@@ -200,6 +200,16 @@ export const Chat = ({
       isRetrying: store.isRetrying,
     })),
   )
+
+  // Stabilize streamingAgents reference - only create new Set when content changes
+  const streamingAgentsKey = useMemo(
+    () => Array.from(rawStreamingAgents).sort().join(','),
+    [rawStreamingAgents],
+  )
+  const streamingAgents = useMemo(
+    () => rawStreamingAgents,
+    [streamingAgentsKey],
+  )
   const pendingBashMessages = useChatStore((state) => state.pendingBashMessages)
 
   // Refs for tracking state across renders
@@ -889,7 +899,7 @@ export const Chat = ({
   useEffect(() => {
     inputValueRef.current = inputValue
   }, [inputValue])
-  
+
   // Report activity on input changes for ad rotation (debounced via separate effect)
   const lastReportedActivityRef = useRef<number>(0)
   useEffect(() => {
@@ -976,7 +986,13 @@ export const Chat = ({
     reportActivity()
     const result = await onSubmitPrompt(inputValue, agentMode)
     handleCommandResult(result)
-  }, [onSubmitPrompt, inputValue, agentMode, handleCommandResult, reportActivity])
+  }, [
+    onSubmitPrompt,
+    inputValue,
+    agentMode,
+    handleCommandResult,
+    reportActivity,
+  ])
 
   const totalMentionMatches = agentMatches.length + fileMatches.length
   const historyNavUpEnabled =

cli/src/components/message-with-agents.tsx

@@ -1,5 +1,5 @@
 import { TextAttributes } from '@opentui/core'
-import { memo, useMemo, type ReactNode } from 'react'
+import { memo, useCallback, useMemo, type ReactNode } from 'react'
 import React from 'react'
 
 import { Button } from './button'
@@ -64,6 +64,18 @@ export const MessageWithAgents = memo(
     const SIDE_GUTTER = 1
     const isAgent = message.variant === 'agent'
 
+    // Memoize onOpenFeedback to prevent unnecessary re-renders
+    const onOpenFeedback = useCallback(
+      (options?: {
+        category?: string
+        footerMessage?: string
+        errors?: Array<{ id: string; message: string }>
+      }) => {
+        onFeedback(message.id, options)
+      },
+      [onFeedback, message.id],
+    )
+
     const contentBoxStyle = useMemo(
       () => ({
         backgroundColor: theme.background,
@@ -209,11 +221,7 @@ export const MessageWithAgents = memo(
                   onFeedback={onFeedback}
                   onCloseFeedback={onCloseFeedback}
                   validationErrors={message.validationErrors}
-                  onOpenFeedback={
-                    onFeedback
-                      ? (options) => onFeedback(message.id, options)
-                      : undefined
-                  }
+                  onOpenFeedback={onOpenFeedback}
                   attachments={message.attachments}
                   metadata={message.metadata}
                   isLastMessage={isLastMessage}