Address ad review simplifications

Author: jahooma

cli/src/hooks/use-gravity-ad.ts

@@ -180,11 +180,6 @@ export const useGravityAd = (options?: {
       })
   }
 
-  // Show a choice ad set (impressions are fired by the component for visible ads only)
-  const showChoiceAds = (ads: AdResponse[]): void => {
-    setAds(ads)
-  }
-
   type FetchAdResult = { ads: AdResponse[] } | null
 
   // Fetch an ad via web API
@@ -303,13 +298,13 @@ export const useGravityAd = (options?: {
         if (result) {
           addToChoiceCache(ctrl, result.ads)
           ctrl.adsShownSinceActivity += 1
-          showChoiceAds(result.ads)
+          setAds(result.ads)
         } else {
           // Fall back to cached ads
           const cachedSet = nextFromChoiceCache(ctrl)
           if (cachedSet) {
             ctrl.adsShownSinceActivity += 1
-            showChoiceAds(cachedSet)
+            setAds(cachedSet)
           }
         }
       } finally {
@@ -338,7 +333,7 @@ export const useGravityAd = (options?: {
       if (result) {
         const ctrl = ctrlRef.current
         addToChoiceCache(ctrl, result.ads)
-        showChoiceAds(result.ads)
+        setAds(result.ads)
         ctrl.adsShownSinceActivity = 1
       }
       setIsLoading(false)

web/src/app/api/v1/ads/_post.ts

@@ -54,10 +54,7 @@ export type AdsEnv = {
 }
 
 function noAdsResponse(provider: AdProviderId) {
-  return NextResponse.json(
-    { ads: [], variant: 'choice', provider },
-    { status: 200 },
-  )
+  return NextResponse.json({ ads: [], provider }, { status: 200 })
 }
 
 export async function postAds(params: {
@@ -202,12 +199,11 @@ export async function postAds(params: {
     }
 
     logger.info(
-      { provider: provider.id, variant: 'choice', adCount: result.ads.length },
-      '[ads] Fetched choice ads',
+      { provider: provider.id, adCount: result.ads.length },
+      '[ads] Fetched ads',
     )
     return NextResponse.json({
       ads: result.ads.map(toClient),
-      variant: 'choice',
       provider: provider.id,
     })
   } catch (error) {
@@ -225,7 +221,6 @@ export async function postAds(params: {
     return NextResponse.json(
       {
         ads: [],
-        variant: 'choice',
         provider: providerId,
         error: getErrorObject(error),
       },