Revert "sprint 3 implement and rewrite - i modified the implement part of get-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks."

This reverts commit c822d53.

Author: Dagim-Daniel

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -34,10 +34,6 @@ function getCardValue(card) {
 
   const faceCardValues = {'A': 11, 'J': 10, 'Q': 10, 'K': 10};
 
-if(faceCardValues[value] === undefined && (Number(value) < 2 || Number(value) > 10)) {
-    throw new Error("Invalid card");
-  }
-  
   if (faceCardValues[value] !== undefined) {
     return faceCardValues[value];
   } 
@@ -63,8 +59,11 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
+
 assertEquals(getCardValue("A♥"),11);
 assertEquals(getCardValue("10♠"),10);
+
+
 assertEquals(getCardValue("2♠"), 2);
 assertEquals(getCardValue("K♠"), 10);
 assertEquals(getCardValue("q♦"), 10);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -14,36 +14,7 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 });
 
 // Case 2: Right angle
-test(`should return "Right angle" when (Angle ===90)`, () => {
-  // Test various acute angles, including boundary cases
-  expect(getAngleType(90)).toEqual("Right angle");
-  
-});
-
 // Case 3: Obtuse angles
-test(`should return "Obtuse angle" when ( 90 < angle < 180)`, () => {
-  // Test various acute angles, including boundary cases
-  expect(getAngleType(91)).toEqual("Obtuse angle");
-  expect(getAngleType(125)).toEqual("Obtuse angle");
-  expect(getAngleType(179)).toEqual("Obtuse angle");
-});
-
 // Case 4: Straight angle
-test(`should return "Straight angle" when (angle === 180)`, () => {
-  // Test various acute angles, including boundary cases
-  expect(getAngleType(180)).toEqual("Straight angle");
-});
 // Case 5: Reflex angles
-test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
-  // Test various reflex angles, including boundary cases
-  expect(getAngleType(181)).toEqual("Reflex angle");
-  expect(getAngleType(270)).toEqual("Reflex angle");
-  expect(getAngleType(359)).toEqual("Reflex angle");
-});
 // Case 6: Invalid angles
-test(`should return "Invalid angle" when (angle < 0 || angle > 360)`, () => {
-  // Test various invalid angles
-  expect(getAngleType(-1)).toEqual("Invalid angle");
-  expect(getAngleType(361)).toEqual("Invalid angle");
-  expect(getAngleType(0)).toEqual("Invalid angle");
-});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -3,27 +3,8 @@
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
-test(`should return True when denominator is positive and  less than numerator`, () => {
-  expect(isProperFraction(1, 2)).toEqual(true);
-  expect(isProperFraction(-1, 2)).toEqual(true );
-  expect(isProperFraction(20, 21)).toEqual(true );
-  expect(isProperFraction(60, 90)).toEqual(true );
-});
-
-test(`should return false when denominator greater than numerator`, () => {
-  expect(isProperFraction(10, 1)).toEqual(false);
-  expect(isProperFraction(11, 1)).toEqual(false);
-});
-
-test(`should return false when denominator and numerators are Equal`, () => {
-  expect(isProperFraction(1, 1)).toEqual(false);
-  expect(isProperFraction(-1,-1)).toEqual(false);
-  expect(isProperFraction(-1, 1)).toEqual(false);
-});
 
 // Special case: numerator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
-  expect(isProperFraction(-1, 0)).toEqual(false);
-  expect(isProperFraction(0, 0)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -11,34 +11,8 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
-test(`Should return 10 when given a number card`, () => {
-  expect(getCardValue("2♠")).toEqual(2);
-  expect(getCardValue("3♦")).toEqual(3);
-  expect(getCardValue("4♣")).toEqual(4);
-  expect(getCardValue("5♠")).toEqual(5);
-  expect(getCardValue("6♦")).toEqual(6);
-  expect(getCardValue("7♣")).toEqual(7);
-  expect(getCardValue("8♠")).toEqual(8);
-  expect(getCardValue("9♦")).toEqual(9);
-  expect(getCardValue("10♣")).toEqual(10);
-});
 //   Face Cards (J, Q, K)
-test(`Should return 10 when given a number card`, () => {
-  expect(getCardValue("K♠")).toEqual(10);
-  expect(getCardValue("q♦")).toEqual(10);
-  expect(getCardValue("J♣")).toEqual(10);
-});
-
 //   Invalid Cards
-test(`Should return Invalid Cards when given invalid inputs`, () => {
-  expect(() => getCardValue("")).toThrow();
-  expect(() => getCardValue("11")).toThrow();
-  expect(() => getCardValue("♠10")).toThrow();
-  expect(() => getCardValue("invalid")).toThrow();
-  expect(() => getCardValue("1♠")).toThrow();
-  expect(() => getCardValue("ab")).toThrow();
-  
-});
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:

package.json

@@ -9,7 +9,7 @@
   "keywords": [],
   "author": "Code Your Future",
   "license": "ISC",
-  "devDependencies": {
-    "jest": "^30.4.2"
+  "dependencies": {
+    "jest": "^29.7.0"
   }
-}
+}