fix: remove extraneous timed_out field, which should refer to the did_timeout field

williams-jack · williams-jack · commit 80423f52e1c9 · 2024-10-09T19:10:09.000-04:00
diff --git a/app/controllers/api/grades_controller.rb b/app/controllers/api/grades_controller.rb
@@ -75,7 +75,7 @@ def orca_response_params
           {
             **shell_response_hash,
             status_code: shell_response_hash[:status_code].to_i,
-            timed_out: shell_response_hash[:timed_out] == 'true'
+            did_timeout: shell_response_hash[:did_timeout] == 'true'
           }
         end
         errors = params[:errors] || []
diff --git a/test/controllers/api/grades_controller_test.rb b/test/controllers/api/grades_controller_test.rb
@@ -54,7 +54,7 @@ class GradesControllerTest < ActionController::TestCase
           stdout: 'TAP output.',
           stderr: '',
           status_code: 0,
-          timed_out: false,
+          did_timeout: false,
           cmd: ['echo', '"TAP output."']
         }],
         errors: []

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ def orca_response_params`
`75`	`75`	`{`
`76`	`76`	`**shell_response_hash,`
`77`	`77`	`status_code: shell_response_hash[:status_code].to_i,`
`78`		`- timed_out: shell_response_hash[:timed_out] == 'true'`
	`78`	`+ did_timeout: shell_response_hash[:did_timeout] == 'true'`
`79`	`79`	`}`
`80`	`80`	`end`
`81`	`81`	`errors = params[:errors] \|\| []`