Skip to content

Commit b7cbbd4

Browse files
authored
Merge pull request #284 from CodIN-INU/revert-283-develop
Revert "hotfix: 닉네임 변경 기능에서 삭제된 닉네임, 자기 자신의 닉네임 사용가능하도록 수정"
2 parents 2219918 + cfd17d3 commit b7cbbd4

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/main/java/inu/codin/codin/common/security/service/AuthCommonService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import inu.codin.codin.common.exception.NotFoundException;
44
import inu.codin.codin.common.security.dto.SignUpAndLoginRequestDto;
5-
import inu.codin.codin.common.security.util.SecurityUtils;
65
import inu.codin.codin.domain.user.dto.request.UserProfileRequestDto;
76
import inu.codin.codin.domain.user.entity.UserEntity;
87
import inu.codin.codin.domain.user.exception.UserCreateFailException;
@@ -34,7 +33,7 @@ public AuthCommonService(UserRepository userRepository, S3Service s3Service, Jwt
3433
}
3534

3635
public void completeUserProfile(UserProfileRequestDto userProfileRequestDto, MultipartFile userImage, HttpServletResponse response) {
37-
Optional<UserEntity> nickNameDuplicate = userRepository.findByNicknameAndDeletedAtIsNull(SecurityUtils.getCurrentUserId(), userProfileRequestDto.getNickname());
36+
Optional<UserEntity> nickNameDuplicate = userRepository.findByNicknameAndDeletedAtIsNull(userProfileRequestDto.getNickname());
3837
if (nickNameDuplicate.isPresent()){
3938
throw new UserNicknameDuplicateException("이미 사용중인 닉네임입니다.");
4039
}

src/main/java/inu/codin/codin/domain/user/repository/UserRepository.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ public interface UserRepository extends MongoRepository<UserEntity, ObjectId> {
1818
@Query("{'email': ?0, 'deletedAt': null, 'status': { $in: ['ACTIVE'] }}")
1919
Optional<UserEntity> findByEmail(String email);
2020

21-
@Query("{'_id': {$ne: ?0}, 'nickname': ?1, 'deletedAt': null}")
22-
Optional<UserEntity> findByNicknameAndDeletedAtIsNull(ObjectId userId, String nickname);
21+
Optional<UserEntity> findByNicknameAndDeletedAtIsNull(String nickname);
2322

2423
@Query("{'email': ?0, 'deletedAt': null, 'status': { $in: ['DISABLED'] }}")
2524
Optional<UserEntity> findByEmailAndDisabled(String email);

src/main/java/inu/codin/codin/domain/user/service/UserService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import org.springframework.data.domain.Page;
3131
import org.springframework.data.domain.PageRequest;
3232
import org.springframework.data.domain.Sort;
33-
import org.springframework.security.core.context.SecurityContextHolder;
3433
import org.springframework.stereotype.Service;
3534
import org.springframework.web.multipart.MultipartFile;
3635

@@ -149,8 +148,9 @@ public UserInfoResponseDto getUserInfo() {
149148
return UserInfoResponseDto.of(user);
150149
}
151150
public void updateUserInfo(@Valid UserNicknameRequestDto userNicknameRequestDto) {
152-
Optional<UserEntity> nickNameDuplicate = userRepository.findByNicknameAndDeletedAtIsNull(SecurityUtils.getCurrentUserId(), userNicknameRequestDto.getNickname());
153-
if (nickNameDuplicate.isPresent()) {
151+
152+
Optional<UserEntity> nickNameDuplicate = userRepository.findByNicknameAndDeletedAtIsNull(userNicknameRequestDto.getNickname());
153+
if (nickNameDuplicate.isPresent()){
154154
throw new UserNicknameDuplicateException("이미 사용중인 닉네임입니다.");
155155
}
156156

0 commit comments

Comments
 (0)