Skip to content

Commit e79d4f4

Browse files
committed
Refactor: based: Clean up includes in pacemaker-based.c
Using include-what-you-use. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
1 parent ceddc60 commit e79d4f4

2 files changed

Lines changed: 32 additions & 37 deletions

File tree

daemons/based/pacemaker-based.c

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,31 @@
99

1010
#include <crm_internal.h>
1111

12+
#include <errno.h> // errno
13+
#include <grp.h> // initgroups
14+
#include <signal.h> // SIGTERM
1215
#include <stdbool.h>
13-
#include <stdio.h>
14-
#include <stdlib.h>
15-
#include <pwd.h>
16-
#include <grp.h>
17-
#include <bzlib.h>
18-
#include <sys/types.h>
19-
20-
#include <glib.h>
21-
#include <libxml/tree.h>
22-
23-
#include <crm/crm.h>
24-
#include <crm/cib/internal.h>
25-
#include <crm/cluster/internal.h>
26-
#include <crm/common/mainloop.h>
27-
#include <crm/common/xml.h>
28-
29-
#include <pacemaker-based.h>
16+
#include <stddef.h> // NULL, size_t
17+
#include <stdlib.h> // free
18+
#include <syslog.h> // LOG_INFO
19+
#include <sys/types.h> // gid_t, uid_t
20+
#include <unistd.h> // setgid, setuid
21+
22+
#include <corosync/cpg.h> // cpg_*
23+
#include <glib.h> // g_*, G_*, etc.
24+
#include <libxml/tree.h> // xmlNode
25+
26+
#include <crm_config.h> // CRM_CONFIG_DIR, CRM_DAEMON_USER
27+
#include <crm/cib/internal.h> // cib_read_config
28+
#include <crm/cluster.h> // pcmk_cluster_*
29+
#include <crm/cluster/internal.h> // pcmk__node_update, etc.
30+
#include <crm/common/ipc.h> // crm_ipc_*
31+
#include <crm/common/logging.h> // crm_log_*
32+
#include <crm/common/mainloop.h> // mainloop_add_signal
33+
#include <crm/common/results.h> // CRM_EX_*, pcmk_rc_*
34+
#include <crm/common/xml.h> // PCMK_XA_REMOTE_*_PORT
35+
36+
#include "pacemaker-based.h"
3037

3138
#define SUMMARY "daemon for managing the configuration of a Pacemaker cluster"
3239

daemons/based/pacemaker-based.h

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,20 @@
1111
# define PACEMAKER_BASED__H
1212

1313
#include <stdbool.h>
14-
#include <stdio.h>
15-
#include <sys/types.h>
16-
#include <unistd.h>
17-
#include <stdlib.h>
18-
#include <glib.h>
19-
#include <errno.h>
20-
#include <fcntl.h>
21-
22-
#include <glib.h>
23-
#include <libxml/tree.h>
24-
25-
#include <crm/crm.h>
26-
#include <crm/cib.h>
27-
#include <crm/common/xml.h>
28-
#include <crm/cluster.h>
29-
#include <crm/common/internal.h>
30-
#include <crm/common/mainloop.h>
31-
#include <crm/cib/internal.h>
14+
#include <stdint.h> // uint32_t, UINT64_C
15+
16+
#include <glib.h> // GHashTable, g_hash_table_lookup
17+
#include <libxml/tree.h> // xmlNode
18+
#include <qb/qbipcs.h> // qb_ipcs_service_t
19+
20+
#include <crm/cluster.h> // pcmk_cluster_t
21+
#include <crm/common/internal.h> // pcmk__client_t
3222

3323
#include "based_io.h"
3424
#include "based_operation.h"
3525
#include "based_notify.h"
3626
#include "based_transaction.h"
3727

38-
#include <gnutls/gnutls.h>
39-
4028
#define OUR_NODENAME (stand_alone? "localhost" : crm_cluster->priv->node_name)
4129

4230
// CIB-specific client flags

0 commit comments

Comments
 (0)