Refactor: based: Ignore cib_discard_reply

Send a reply even if the cib_discard_reply flag is set. The client will
still discard the reply. (TODO: The client discards the reply for sync
requests but still needs to discard it for async.)

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/based_callbacks.c

@@ -337,9 +337,7 @@ parse_peer_options(const cib__operation_t *operation, pcmk__request_t *request,
      * to all nodes. Also don't send a reply if the client specifically told us
      * not to.
      */
-    const bool can_reply = !operation->modifies_cib
-                           && !pcmk__is_set(request->call_options,
-                                            cib_discard_reply);
+    const bool can_reply = !operation->modifies_cib;
 
     const char *host = pcmk__xe_get(request->xml, PCMK__XA_CIB_HOST);
     const char *delegated = pcmk__xe_get(request->xml,
@@ -746,11 +744,6 @@ based_handle_request(pcmk__request_t *request)
         return pcmk_rc_ok;
     }
 
-    if (pcmk__is_set(request->call_options, cib_discard_reply)) {
-        local_notify = false;
-        pcmk__trace("Client is not interested in the reply");
-    }
-
     if (cib_status != pcmk_rc_ok) {
         rc = cib_status;
         pcmk__err("Ignoring request because cluster configuration is invalid "