Skip to content

Commit 36d298c

Browse files
authored
Fix commit for DiskObjectStorage (ClickHouse#50599)
1 parent e873480 commit 36d298c

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

src/Disks/ObjectStorages/DiskObjectStorage.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,8 @@ void DiskObjectStorage::writeFileUsingBlobWritingFunction(const String & path, W
596596
{
597597
LOG_TEST(log, "Write file: {}", path);
598598
auto transaction = createObjectStorageTransaction();
599-
return transaction->writeFileUsingBlobWritingFunction(path, mode, std::move(write_blob_function));
599+
transaction->writeFileUsingBlobWritingFunction(path, mode, std::move(write_blob_function));
600+
transaction->commit();
600601
}
601602

602603
void DiskObjectStorage::applyNewSettings(

src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,6 @@ void DiskObjectStorageTransaction::writeFileUsingBlobWritingFunction(
710710
metadata_transaction->createMetadataFile(path, blob_name, object_size);
711711
else
712712
metadata_transaction->addBlobToMetadata(path, blob_name, object_size);
713-
714-
metadata_transaction->commit();
715713
}
716714

717715

0 commit comments

Comments
 (0)