ci: extract quality-checks job and standardize test output

Move lint, PHP CS Fixer, and PHPStan into a dedicated quality-checks
job that gates integration-test. Remove duplicate steps from the
integration job. Standardize regression test output to use print
instead of echo.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

.github/workflows/plugin-ci-workflow.yml

@@ -32,7 +32,65 @@ on:
       - develop
 
 jobs:
+  quality-checks:
+    name: PHP Quality (Lint, Stan, CS)
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout Cacti
+      uses: actions/checkout@v4
+      with:
+        repository: Cacti/cacti
+        path: cacti
+    
+    - name: Checkout Syslog Plugin
+      uses: actions/checkout@v4
+      with:
+        path: cacti/plugins/syslog
+    
+    - name: Setup PHP 8.3
+      uses: shivammathur/setup-php@v2
+      with:
+        php-version: '8.3'
+        extensions: intl, mysql, gd, ldap, gmp, xml, curl, json, mbstring
+        tools: php-cs-fixer, phpstan
+
+    - name: Check PHP Syntax (Lint)
+      run: |
+        cd cacti/plugins/syslog
+        if find . -name '*.php' -not -path './vendor/*' -exec php -l {} 2>&1 \; | grep -iv 'no syntax errors detected'; then
+          echo "Syntax errors found!"
+          exit 1
+        fi
+
+    - name: Run PHP CS Fixer (Dry Run)
+      run: |
+        cd cacti/plugins/syslog
+        php-cs-fixer fix --dry-run --diff --ansi --config=../../../.php-cs-fixer.php . || true
+
+    - name: Create PHPStan config
+      run: |
+        cd cacti/plugins/syslog
+        cat > phpstan.neon << 'EOF'
+        parameters:
+          level: 5
+          paths:
+            - .
+          excludePaths:
+            - vendor/
+            - locales/
+          ignoreErrors:
+            - '#has invalid return type the\.#'
+          bootstrapFiles:
+            - ../../include/global.php
+        EOF
+
+    - name: Run PHPStan Analysis
+      run: |
+        cd cacti/plugins/syslog
+        phpstan analyse --no-progress --error-format=github || true
+
   integration-test:
+    needs: quality-checks
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -147,7 +205,7 @@ jobs:
         sed -i "s/'cacti'/'cacti'/g" ${{ github.workspace }}/cacti/plugins/syslog/config.php
         sed -i "s/'cactiuser'/'cactiuser'/g" ${{ github.workspace }}/cacti/plugins/syslog/config.php
         sed -i 's/\/\/\$/\$/g' ${{ github.workspace }}/cacti/plugins/syslog/config.php
-        sudo chmod 664 ${{ github.workspace }}/cacti/plugins/syslog/config.php
+        sudo chmod 664 ${{ github.workspace }}/cacti/include/config.php
     
     - name: Configure Apache
       run: |
@@ -178,14 +236,6 @@ jobs:
       run: |
         cd ${{ github.workspace }}/cacti
         sudo php cli/plugin_manage.php --plugin=syslog --install --enable
-    
-    - name: Check PHP Syntax for Plugin
-      run: |
-        cd ${{ github.workspace }}/cacti/plugins/syslog
-        if find . -name '*.php' -exec php -l {} 2>&1 \; | grep -iv 'no syntax errors detected'; then
-          echo "Syntax errors found!"
-          exit 1
-        fi
 
     - name: Run Plugin Regression Tests
       run: |
@@ -233,38 +283,3 @@ jobs:
           echo "=== Cacti Log ==="
           sudo cat ${{ github.workspace }}/cacti/log/cacti.log
         fi
-
-
-    - name: Create PHPStan config
-      run: |
-        cd ${{ github.workspace }}/cacti/plugins/syslog
-        cat > phpstan.neon << 'EOF'
-        parameters:
-          level: 5
-          paths:
-            - .
-          excludePaths:
-            - vendor/
-            - locales/
-          ignoreErrors:
-            - '#has invalid return type the\.#'
-          bootstrapFiles:
-            - ../../include/global.php
-        EOF
-    
-    - name: Install PHPStan
-      run: |
-        cd ${{ github.workspace }}/cacti/plugins/syslog
-        composer require --dev phpstan/phpstan --with-all-dependencies || composer global require phpstan/phpstan
-    
-    - name: Run PHPStan Analysis
-      run: |
-        cd ${{ github.workspace }}/cacti/plugins/syslog
-        if [ -f vendor/bin/phpstan ]; then
-          vendor/bin/phpstan analyse --no-progress --error-format=github || true
-        else
-          phpstan analyse --no-progress --error-format=github || true
-        fi
-      continue-on-error: true
-
-

tests/regression/issue252_xss_output_test.php

@@ -42,4 +42,4 @@
 	exit(1);
 }
 
-echo "issue252_xss_output_test passed\n";
+print "issue252_xss_output_test passed\n";

tests/regression/issue254_partition_table_locking_test.php

@@ -186,4 +186,4 @@
 	exit(1);
 }
 
-echo "issue254_partition_table_locking_test passed\n";
+print "issue254_partition_table_locking_test passed\n";

tests/regression/issue259_csrf_purge_test.php

@@ -103,4 +103,4 @@
 	exit(1);
 }
 
-echo "issue259_csrf_purge_test passed\n";
+print "issue259_csrf_purge_test passed\n";

tests/regression/issue260_remove_eval_callback_test.php

@@ -42,4 +42,4 @@
 	exit(1);
 }
 
-echo "issue260_remove_eval_callback_test passed\n";
+print "issue260_remove_eval_callback_test passed\n";

tests/regression/issue261_domain_strip_parameterized_test.php

@@ -24,4 +24,4 @@
 	exit(1);
 }
 
-echo "issue261_domain_strip_parameterized_test passed\n";
+print "issue261_domain_strip_parameterized_test passed\n";

tests/regression/issue270_mariadb_detection_strict_test.php

@@ -20,4 +20,4 @@
 	exit(1);
 }
 
-echo "issue270_mariadb_detection_strict_test passed\n";
+print "issue270_mariadb_detection_strict_test passed\n";