moved deprecated functions into settings component, so it's usage is at least confined to this one component

Author: Vegita2

webapp/src/app/components/dialogs/settings/settings.component.ts

@@ -43,8 +43,8 @@ import { MatCheckbox } from '@angular/material/checkbox';
 		MatOption,
 		ColoredTextDirective,
 		MatCheckbox,
-		ImageSelectCardComponent
-	]
+		ImageSelectCardComponent,
+	],
 })
 export class SettingsComponent implements OnInit {
 	private ref = inject(OverlayRefControl);
@@ -78,7 +78,11 @@ export class SettingsComponent implements OnInit {
 
 		http.getMods().subscribe(mods => this.mods = mods);
 		this.mod = this.sharedService.getSelectedMod();
-		this.settings = JSON.parse(JSON.stringify(this.settingsService.getSettings()));
+		
+		this.settings = {} as AppSettings;
+		for (const [key, val] of Object.entries(this.settingsService.signalSettings())) {
+			this.settings[key as keyof AppSettings] = val();
+		}
 	}
 
 	ngOnInit() {
@@ -119,7 +123,7 @@ export class SettingsComponent implements OnInit {
 			this.folderFormControl.setErrors(null);
 		} else {
 			this.folderFormControl.setErrors({
-				invalid: true
+				invalid: true,
 			});
 		}
 	}
@@ -129,10 +133,16 @@ export class SettingsComponent implements OnInit {
 			this.electron.saveAssetsPath(this.folderFormControl.value);
 		}
 		this.sharedService.saveModSelect(this.mod);
-		this.settingsService.updateSettings(this.settings);
+		
+		const settings = this.settingsService.signalSettings();
+		for (const [k, val] of Object.entries(this.settings)) {
+			const key = k as keyof AppSettings;
+			settings[key].set(val);
+		}
+		
 		this.close();
 		const ref = this.snackBar.open('Changing the path requires to restart the editor', 'Restart', {
-			duration: 6000
+			duration: 6000,
 		});
 
 		ref.onAction().subscribe(() => this.sharedService.relaunch());

webapp/src/app/components/widgets/event-widget/event-editor/editor/event-editor.component.ts

@@ -82,7 +82,7 @@ export class EventEditorComponent implements OnChanges, OnInit {
 	private copiedNode?: EventDisplay;
 
 	ngOnInit() {
-		this.wrapText = this.settingsService.getSettings().wrapEventEditorLines;
+		this.wrapText = this.settingsService.signalSettings().wrapEventEditorLines();
 	}
 
 	ngOnChanges() {

webapp/src/app/services/phaser/BaseTileDrawer.ts

@@ -243,7 +243,7 @@ export class BaseTileDrawer extends BaseObject {
 
 		let textColor = 'rgba(0,0,0,0.6)';
 		let backgroundColor = 0xffffff;
-		if (Globals.settingsService.getSettings().selectionBoxDark) {
+		if (Globals.settingsService.signalSettings().selectionBoxDark()) {
 			textColor = 'rgba(255,255,255,0.9)';
 			backgroundColor = 0x333333;
 		}

webapp/src/app/services/settings.service.ts

@@ -29,17 +29,6 @@ export class SettingsService {
 		}
 	}
 
-	/**
-	 * @deprecated Use signalSettings instead.
-	 */
-	getSettings(): Readonly<AppSettings> {
-		const out = {} as AppSettings;
-		for (const [key, val] of Object.entries(this.settings)) {
-			out[key as keyof AppSettings] = val();
-		}
-		return out;
-	}
-	
 	signalSettings(): Signalify<AppSettings> {
 		return this.settings;
 	}
@@ -49,14 +38,4 @@ export class SettingsService {
 		const val = loadedValue === null ? defaultValue : (loadedValue === 'true');
 		return signal(val);
 	}
-	
-	/**
-	 * @deprecated set signals directly instead
-	 */
-	public updateSettings(newSettings: Partial<AppSettings>) {
-		for (const [k, val] of Object.entries(newSettings)) {
-			const key = k as keyof AppSettings;
-			this.settings[key].set(val);
-		}
-	}
 }