[bugfix] Fix error in path handling when opening config file from UI #252

Author: Breakthrough

docs/changelog.md

@@ -391,5 +391,6 @@ This version of DVR-Scan includes a new, faster background subtraction algorithm
 
 ### 1.9
 
- - [general] Minimum Python version is now 3.10 ([EOL](https://devguide.python.org/versions/))
+ * [general] Minimum Python version is now 3.10 ([EOL](https://devguide.python.org/versions/))
  * [bugfix] Fix `quiet-mode` setting (`-q`/`--quiet` flag) still allowing extraneous output
+ * [bugfix] Fix loading config from file in UI

dvr_scan/config.py

@@ -434,6 +434,10 @@ def load(self, path: ty.Optional[Path] = None):
             ConfigLoadFailure: The config file being loaded is corrupt or invalid,
             or `path` was specified but does not exist.
         """
+        # Allow passing in str paths for convenience.
+        if path and not isinstance(path, Path):
+            path = Path(path)
+
         # Validate `path`, or if not provided, use USER_CONFIG_FILE_PATH if it exists.
         if path:
             self._log(logging.INFO, "Loading config from file: %s" % path)

dvr_scan/controller.py

@@ -98,7 +98,7 @@ def parse_settings() -> ty.Optional[ScanSettings]:
             init_log += config.consume_init_log()
         if hasattr(args, "config"):
             config_setting = ConfigRegistry()
-            config_setting.load(Path(args.config))
+            config_setting.load(args.config)
             init_logging(args, config_setting)
             config = config_setting
         init_log += config.consume_init_log()