AB#43 Sonar medium issues. (#16)

Author: BlaiseD

LogicBuilder.ComponentModel.Design.Serialization.Tests/DesignerSerializationManagerTests.cs

@@ -623,6 +623,22 @@ public void CreateInstance_ThrowsSerializationExceptionForMissingConstructor()
             }
         }
 
+        [Fact]
+        public void CreateInstance_ThrowsSerializationExceptionForMissingConstructor_WithNullParameters()
+        {
+            // Arrange
+            var manager = (IDesignerSerializationManager)new DesignerSerializationManager();
+
+            // Act & Assert
+            using (((DesignerSerializationManager)manager).CreateSession())
+            {
+                var exception = Assert.Throws<System.Runtime.Serialization.SerializationException>(() =>
+                    manager.CreateInstance(typeof(TestClassWithConstructor), null, "test", false));
+
+                Assert.Contains("TestClassWithConstructor", exception.Message);
+            }
+        }
+
         [Fact]
         public void CreateInstance_ConvertsParametersForConstructor()
         {

LogicBuilder.ComponentModel.Design.Serialization/DesignerSerializationManager.cs

@@ -532,7 +532,7 @@ protected virtual object CreateInstance(Type type, ICollection arguments, string
                 {
                     StringBuilder stringBuilder = new();
                     object[] array4 = array;
-                    for (int l = 0; l < array4.Length; l++)
+                    for (int l = 0; array4 != null && l < array4.Length; l++)
                     {
                         object obj2 = array4[l];
                         if (stringBuilder.Length > 0)
@@ -630,7 +630,7 @@ public object GetSerializer(Type objectType, Type serializerType)
                                     Type runtimeType2 = this.GetRuntimeType(designerSerializerAttribute.SerializerTypeName);
                                     if (runtimeType2 != null)
                                     {
-                                        obj = Activator.CreateInstance(runtimeType2, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);
+                                        obj = Activator.CreateInstance(runtimeType2, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);// NOSONAR
                                         break;
                                     }
                                 }
@@ -653,7 +653,7 @@ public object GetSerializer(Type objectType, Type serializerType)
                     type = this.GetRuntimeType(defaultSerializationProviderAttribute.ProviderTypeName);
                     if (type != null && typeof(IDesignerSerializationProvider).IsAssignableFrom(type))
                     {
-                        IDesignerSerializationProvider designerSerializationProvider = (IDesignerSerializationProvider)Activator.CreateInstance(type, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);
+                        IDesignerSerializationProvider designerSerializationProvider = (IDesignerSerializationProvider)Activator.CreateInstance(type, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.CreateInstance, null, null, null);// NOSONAR
                         ((IDesignerSerializationManager)this).AddSerializationProvider(designerSerializationProvider);
                     }
                 }

README.md

@@ -3,6 +3,7 @@
 [![Build Status](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/ci.yml/badge.svg)](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/ci.yml)
 [![CodeQL](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/github-code-scanning/codeql/badge.svg)](https://github.com/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/actions/workflows/github-code-scanning/codeql)
 [![codecov](https://codecov.io/gh/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization/graph/badge.svg?token=PFDB2PEVZT)](https://codecov.io/gh/BpsLogicBuilder/LogicBuilder.ComponentModel.Design.Serialization)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=BpsLogicBuilder_LogicBuilder.ComponentModel.Design.Serialization&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=BpsLogicBuilder_LogicBuilder.ComponentModel.Design.Serialization)
 [![NuGet](https://img.shields.io/nuget/v/LogicBuilder.ComponentModel.Design.Serialization.svg)](https://www.nuget.org/packages/LogicBuilder.ComponentModel.Design.Serialization)
 
 ## Serialization Management