fix(android): port 60 missing bloom_* FFI exports (parity with linux/macOS) + v0.4.14#59
Merged
Merged
Conversation
…ux/macOS The Android native lib (bloom-android) exported 209 bloom_* FFI functions vs 265 on linux/macOS — 60 were missing (scene graph, lighting, post-FX, picking, render-textures, frame callbacks, splat impulse). Because perry statically links the engine into libperry_app.so, the undefined symbols (first hit: bloom_splat_impulse, referenced from core/index.ts) crashed dlopen at launch with UnsatisfiedLinkError on every Perry-built Android app. Ported the implementations verbatim from native/linux/src/lib.rs (Android shares the same wgpu renderer + scene crate) plus the two backing statics they use (LAST_PICK, LAST_PROJECT). Verified: cargo check --target aarch64-linux-android passes. Mirrors 4af46ac (tvOS parity).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bloom-androidexported 209bloom_*FFI functions vs 265 on linux/macOS — 60 missing (scene graph, lighting, post-FX, picking, render-textures, frame callbacks,bloom_splat_impulse).Perry statically links the engine into
libperry_app.so, and the engine's shared TS (core/index.ts) references these symbols, so every Perry-built Android app crashed at launch:Fix
native/linux/src/lib.rs(Android shares the same wgpu renderer + scene crate, so no behavioural change vs linux).LAST_PICK,LAST_PROJECT.Verification
cargo check --target aarch64-linux-androidpasses (only pre-existing unused-var warnings). A Perry Android build against this lib loads + runs instead of crashing ondlopen.Mirrors #58-era parity work and 4af46ac (tvOS parity).