Merge pull request #8086 from BitGo/CGARD-273

refactor(abstract-eth): support signing by default

Author: kamleshmugdiya

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -531,6 +531,16 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
     return true;
   }
 
+  /** @inheritDoc */
+  supportsMessageSigning(): boolean {
+    return true;
+  }
+
+  /** @inheritDoc */
+  supportsSigningTypedData(): boolean {
+    return true;
+  }
+
   /**
    * Default expire time for a contract call (1 week)
    * @returns {number} Time in seconds

modules/sdk-coin-arbeth/src/arbeth.ts

@@ -32,16 +32,6 @@ export class Arbeth extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   /**
    * Make a query to Arbiscan for information such as balance, token balance, solidity calls
    * @param {Object} query key-value pairs of parameters to append after /api

modules/sdk-coin-bsc/src/bsc.ts

@@ -30,16 +30,6 @@ export class Bsc extends AbstractEthLikeNewCoins {
     return true;
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.tss;

modules/sdk-coin-eth/src/eth.ts

@@ -549,14 +549,4 @@ export class Eth extends AbstractEthLikeNewCoins {
   protected getTransactionBuilder(): TransactionBuilder {
     return new TransactionBuilder(coins.get(this.getBaseChain()));
   }
-
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
 }

modules/sdk-coin-evm/src/evmCoin.ts

@@ -44,16 +44,6 @@ export class EvmCoin extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   protected async buildUnsignedSweepTxnTSS(params: RecoverOptions): Promise<OfflineVaultTxInfo | UnsignedSweepTxMPCv2> {
     if (this.staticsCoin?.features.includes(CoinFeature.MPCV2)) {
       return this.buildUnsignedSweepTxnMPCv2(params);

modules/sdk-coin-flr/src/flr.ts

@@ -85,16 +85,6 @@ export class Flr extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   protected async buildUnsignedSweepTxnTSS(params: RecoverOptions): Promise<OfflineVaultTxInfo | UnsignedSweepTxMPCv2> {
     return this.buildUnsignedSweepTxnMPCv2(params);
   }

modules/sdk-coin-mon/src/mon.ts

@@ -46,16 +46,6 @@ export class Mon extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   protected async buildUnsignedSweepTxnTSS(params: RecoverOptions): Promise<OfflineVaultTxInfo | UnsignedSweepTxMPCv2> {
     return this.buildUnsignedSweepTxnMPCv2(params);
   }

modules/sdk-coin-opeth/src/opeth.ts

@@ -32,16 +32,6 @@ export class Opeth extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   /**
    * Make a query to Optimism Etherscan for information such as balance, token balance, solidity calls
    * @param {Object} query key-value pairs of parameters to append after /api

modules/sdk-coin-polygon/src/polygon.ts

@@ -52,16 +52,6 @@ export class Polygon extends AbstractEthLikeNewCoins {
     return await recoveryBlockchainExplorerQuery(query, explorerUrl as string, apiToken);
   }
 
-  /** @inheritDoc */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
-  /** @inheritDoc */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   /** @inheritDoc */
   supportsTss(): boolean {
     return true;

modules/sdk-coin-tempo/src/tempo.ts

@@ -71,13 +71,6 @@ export class Tempo extends AbstractEthLikeNewCoins {
     return 'ecdsa';
   }
 
-  /**
-   * Check if message signing is supported
-   */
-  supportsMessageSigning(): boolean {
-    return true;
-  }
-
   /**
    * Evaluates whether an address string is valid for Tempo
    * Supports addresses with optional memoId query parameter (e.g., 0x...?memoId=123)
@@ -174,13 +167,6 @@ export class Tempo extends AbstractEthLikeNewCoins {
     return true;
   }
 
-  /**
-   * Check if typed data signing is supported (EIP-712)
-   */
-  supportsSigningTypedData(): boolean {
-    return true;
-  }
-
   /**
    * Build unsigned sweep transaction for TSS
    * TODO: Implement sweep transaction logic