feat(abstract-utxo): update parseTransactionWithWalletKeys to use nested

replayProtection parameter

Updates all calls to parseTransactionWithWalletKeys to use the new parameter
structure where replayProtection is nested within an options object.

Issue: BTC-0

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -159,7 +159,7 @@ function hasKeyPathSpendInput<TNumber extends number | bigint>(
     assert(pubs && isTriple(pubs), 'pub triple is required to check for key path spend inputs in wasm-utxo PSBT');
     const rootWalletKeys = fixedScriptWallet.RootWalletKeys.fromXpubs(pubs);
     const replayProtection = { publicKeys: getReplayProtectionPubkeys(coinName) };
-    const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, replayProtection);
+    const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, { replayProtection });
     return parsed.inputs.some((input) => input.scriptType === 'p2trMusig2KeyPath');
   }
   return false;

modules/abstract-utxo/src/transaction/fixedScript/explainPsbtWasm.ts

@@ -49,7 +49,7 @@ export function explainPsbtWasm(
     customChangeWalletXpubs?: Triple<string>;
   }
 ): TransactionExplanationWasm {
-  const parsed = psbt.parseTransactionWithWalletKeys(walletXpubs, params.replayProtection);
+  const parsed = psbt.parseTransactionWithWalletKeys(walletXpubs, { replayProtection: params.replayProtection });
 
   const changeOutputs: FixedScriptWalletOutput[] = [];
   const outputs: Output[] = [];

modules/abstract-utxo/src/transaction/fixedScript/signPsbtWasm.ts

@@ -24,7 +24,7 @@ function hasKeyPathSpendInput(
   rootWalletKeys: fixedScriptWallet.RootWalletKeys,
   replayProtection: ReplayProtectionKeys
 ): boolean {
-  const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, replayProtection);
+  const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, { replayProtection });
   return parsed.inputs.some((input) => input.scriptType === 'p2trMusig2KeyPath');
 }
 
@@ -49,7 +49,7 @@ export function signAndVerifyPsbtWasm(
   }
 
   // Verify signatures for all signed inputs (still per-input for granular error reporting)
-  const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, replayProtection);
+  const parsed = tx.parseTransactionWithWalletKeys(rootWalletKeys, { replayProtection });
   const verifyErrors: InputSigningError<bigint>[] = [];
 
   parsed.inputs.forEach((input, inputIndex) => {

modules/abstract-utxo/test/unit/postProcessPrebuild.ts

@@ -34,7 +34,7 @@ describe('Post Build Validation', function () {
     resultPsbt.lockTime.should.equal(0);
 
     // Check sequences via parseTransactionWithWalletKeys
-    const parsed = resultPsbt.parseTransactionWithWalletKeys(walletKeys, { publicKeys: [] });
+    const parsed = resultPsbt.parseTransactionWithWalletKeys(walletKeys, { replayProtection: { publicKeys: [] } });
     for (const input of parsed.inputs) {
       input.sequence.should.equal(0xffffffff);
     }

modules/abstract-utxo/test/unit/recovery/backupKeyRecovery.ts

@@ -93,7 +93,9 @@ function run(
       );
 
       // Parse generated PSBT
-      parsed = psbt.parseTransactionWithWalletKeys(wasmWalletKeys, { publicKeys: replayProtection });
+      parsed = psbt.parseTransactionWithWalletKeys(wasmWalletKeys, {
+        replayProtection: { publicKeys: replayProtection },
+      });
 
       // Load and parse fixture PSBT
       const psbtHex = Buffer.from(psbt.serialize()).toString('hex');
@@ -104,7 +106,9 @@ function run(
         Buffer.from(storedFixture.psbtHex, 'hex'),
         fixtureCoin.name
       );
-      fixtureParsed = fixturePsbt.parseTransactionWithWalletKeys(wasmWalletKeys, { publicKeys: replayProtection });
+      fixtureParsed = fixturePsbt.parseTransactionWithWalletKeys(wasmWalletKeys, {
+        replayProtection: { publicKeys: replayProtection },
+      });
     });
 
     it('has expected input count', function () {

modules/abstract-utxo/test/unit/recovery/crossChainRecovery.ts

@@ -163,7 +163,7 @@ function run<TNumber extends number | bigint = number>(sourceCoin: AbstractUtxoC
     function checkRecoveryPsbtSignature(psbtHex: string) {
       // Parse using wasm-utxo for signature verification
       const wasmPsbt = fixedScriptWallet.BitGoPsbt.fromBytes(Buffer.from(psbtHex, 'hex'), sourceCoin.name);
-      const parsed = wasmPsbt.parseTransactionWithWalletKeys(wasmWalletKeys, { publicKeys: [] });
+      const parsed = wasmPsbt.parseTransactionWithWalletKeys(wasmWalletKeys, { replayProtection: { publicKeys: [] } });
       const unspents = getRecoveryUnspents();
       should.equal(parsed.inputs.length, unspents.length);
       // Verify user key has signed each input (same pattern as backupKeyRecovery test)

modules/abstract-utxo/test/unit/transaction/fixedScript/signPsbt.ts

@@ -66,7 +66,7 @@ function assertSignedWasm(
   replayProtection: ReplayProtectionKeys
 ): void {
   const wasmUserKey = BIP32.from(userKey);
-  const parsed = psbt.parseTransactionWithWalletKeys(rootWalletKeys, replayProtection);
+  const parsed = psbt.parseTransactionWithWalletKeys(rootWalletKeys, { replayProtection });
 
   // Verify that all wallet inputs have been signed by user key
   parsed.inputs.forEach((input, inputIndex) => {

modules/abstract-utxo/test/unit/util/transaction.ts

@@ -50,8 +50,12 @@ export function assertEqualParsedPsbt(
   }
   const aPsbt = fixedScriptWallet.BitGoPsbt.fromBytes(a, coinName);
   const bPsbt = fixedScriptWallet.BitGoPsbt.fromBytes(b, coinName);
-  const aParsed = aPsbt.parseTransactionWithWalletKeys(walletKeys, { publicKeys: replayProtection });
-  const bParsed = bPsbt.parseTransactionWithWalletKeys(walletKeys, { publicKeys: replayProtection });
+  const aParsed = aPsbt.parseTransactionWithWalletKeys(walletKeys, {
+    replayProtection: { publicKeys: replayProtection },
+  });
+  const bParsed = bPsbt.parseTransactionWithWalletKeys(walletKeys, {
+    replayProtection: { publicKeys: replayProtection },
+  });
   assert.deepStrictEqual(aParsed, bParsed);
 }