Address comments

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/odbc_impl/system_dsn.cc

@@ -20,6 +20,7 @@
 #include "arrow/result.h"
 #include "arrow/util/utf8.h"
 
+#include <boost/algorithm/string/predicate.hpp>
 #include <sstream>
 
 namespace arrow::flight::sql::odbc {
@@ -38,7 +39,7 @@ void PostArrowUtilError(arrow::Status error_status) {
   std::wstring werror_msg = arrow::util::UTF8ToWideString(error_msg).ValueOr(
       L"Error during utf8 to wide string conversion");
 
-  PostError(ODBC_ERROR_GENERAL_ERR, (LPWSTR)werror_msg.c_str());
+  PostError(ODBC_ERROR_GENERAL_ERR, const_cast<LPWSTR>(werror_msg.c_str()));
 }
 
 void PostLastInstallerError() {
@@ -51,7 +52,7 @@ void PostLastInstallerError() {
   buf << L"Message: \"" << msg << L"\", Code: " << code;
   std::wstring error_msg = buf.str();
 
-  PostError(code, (LPWSTR)error_msg.c_str());
+  PostError(code, const_cast<LPWSTR>(error_msg.c_str()));
 }
 
 /**

cpp/src/arrow/flight/sql/odbc/odbc_impl/win_system_dsn.cc

@@ -144,7 +144,7 @@ BOOL INSTAPI ConfigDSNW(HWND hwnd_parent, WORD req, LPCWSTR wdriver,
         std::wstring werror_msg =
             arrow::util::UTF8ToWideString(error_msg).ValueOr(L"Error during DSN load");
 
-        PostError(err.GetNativeError(), (LPWSTR)werror_msg.c_str());
+        PostError(err.GetNativeError(), const_cast<LPWSTR>(werror_msg.c_str()));
         return FALSE;
       }
 

cpp/src/arrow/flight/sql/odbc/tests/type_info_test.cc

@@ -1769,7 +1769,7 @@ TEST_F(TypeInfoOdbcV2MockTest, TestSQLGetTypeInfoTimeODBCVer2) {
 
 TEST_F(TypeInfoOdbcV2MockTest, TestSQLGetTypeInfoSQLTypeTime) {
 #ifdef __APPLE__
-  ASSERT_EQ(SQL_SUCCESS, SQLGetTypeInfo(stmt, SQL_TYPE_DATE));
+  ASSERT_EQ(SQL_SUCCESS, SQLGetTypeInfo(stmt, SQL_TYPE_TIME));
 #else
   // Pass ODBC Ver 3 data type
   ASSERT_EQ(SQL_ERROR, SQLGetTypeInfo(stmt, SQL_TYPE_TIME));