Disable SQLGetConnectOption on macOS

Author: alinaliBQ

cpp/src/arrow/flight/sql/odbc/entry_points.cc

@@ -106,29 +106,10 @@ SQLRETURN SQL_API SQLSetEnvAttr(SQLHENV env, SQLINTEGER attr, SQLPOINTER value_p
 SQLRETURN SQL_API SQLGetConnectAttr(SQLHDBC conn, SQLINTEGER attribute,
                                     SQLPOINTER value_ptr, SQLINTEGER buffer_length,
                                     SQLINTEGER* string_length_ptr) {
-  ARROW_LOG(DEBUG)
-      << "-AL- Alina test msg in entry_points.cc: SQLGetConnectAttr called with conn: "
-      << conn;  //-AL- refactor later.
   return arrow::flight::sql::odbc::SQLGetConnectAttr(conn, attribute, value_ptr,
                                                      buffer_length, string_length_ptr);
 }
 
-// -AL- not sure if needed on macOS, check again after implementing SQLError.
-SQLRETURN SQL_API SQLGetConnectOption(SQLHDBC conn, SQLUSMALLINT attribute,
-                                      SQLPOINTER value_ptr) {
-  ARROW_LOG(DEBUG) << "SQLGetConnectOption called with conn: " << conn
-                   << ", attribute: " << attribute
-                   << ", value_ptr: " << static_cast<const void*>(value_ptr);
-
-  // cast `SQLUSMALLINT` attribute to a `SQLINTEGER` type which works for
-  // SQLGetConnectAttr buffer_length, string_length_ptr should be set to 0
-  SQLINTEGER buffer_length = 0;
-  SQLINTEGER string_length = 0;
-  SQLINTEGER attribute_int = static_cast<SQLINTEGER>(attribute);
-  return arrow::flight::sql::odbc::SQLGetConnectAttr(conn, attribute_int, value_ptr,
-                                                     buffer_length, &string_length);
-}
-
 SQLRETURN SQL_API SQLSetConnectAttr(SQLHDBC conn, SQLINTEGER attr, SQLPOINTER value,
                                     SQLINTEGER value_len) {
   return arrow::flight::sql::odbc::SQLSetConnectAttr(conn, attr, value, value_len);

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

@@ -780,9 +780,6 @@ SQLRETURN SQLGetConnectAttr(SQLHDBC conn, SQLINTEGER attribute, SQLPOINTER value
                    << ", attribute: " << attribute << ", value_ptr: " << value_ptr
                    << ", buffer_length: " << buffer_length << ", string_length_ptr: "
                    << static_cast<const void*>(string_length_ptr);
-  ARROW_LOG(DEBUG)
-      << "-AL- Alina test msg in odbc_api.cc: SQLGetConnectAttr called with conn: "
-      << conn;  //-AL- refactor later.
   using ODBC::ODBCConnection;
 
   return ODBCConnection::ExecuteWithDiagnostics(conn, SQL_ERROR, [=]() {

cpp/src/arrow/flight/sql/odbc/tests/errors_test.cc

@@ -472,12 +472,17 @@ TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorEnvErrorFromDriverManager) {
   EXPECT_TRUE(!std::wstring(message).empty());
 }
 
+#ifndef __APPLE__
 TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorConnError) {
   // Test ODBC 2.0 API SQLError with ODBC ver 2.
   // Known Windows Driver Manager (DM) behavior:
   // When application passes buffer length greater than SQL_MAX_MESSAGE_LENGTH (512),
   // DM passes 512 as buffer length to SQLError.
 
+  // Known macOS Driver Manager (DM) behavior:
+  // Attempts to call SQLGetConnectOption without redirecting the API call to SQLGetConnectAttr.
+  // SQLGetConnectOption is not implemented as it is not required by macOS Excel.
+
   // Attempt to set unsupported attribute
   ASSERT_EQ(SQL_ERROR, SQLGetConnectAttr(this->conn, SQL_ATTR_TXN_ISOLATION, 0, 0, 0));
 
@@ -497,6 +502,7 @@ TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorConnError) {
 
   EXPECT_TRUE(!std::wstring(message).empty());
 }
+#endif // __APPLE__
 
 TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorStmtError) {
   // Test ODBC 2.0 API SQLError with ODBC ver 2.