Skip to content

Commit 3920e26

Browse files
committed
Fix segfault at SQLError
1 parent b0f11c8 commit 3920e26

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

cpp/src/arrow/flight/sql/odbc/tests/errors_test.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -541,19 +541,18 @@ TYPED_TEST(ErrorsOdbcV2Test, TestSQLErrorStmtError) {
541541
// When application passes buffer length greater than SQL_MAX_MESSAGE_LENGTH (512),
542542
// DM passes 512 as buffer length to SQLError.
543543

544-
std::wstring wsql = L"1";
544+
std::wstring wsql = L"SELECT * from non_existent_table;";
545545
std::vector<SQLWCHAR> sql0(wsql.begin(), wsql.end());
546546

547547
ASSERT_EQ(SQL_ERROR,
548548
SQLExecDirect(this->stmt, &sql0[0], static_cast<SQLINTEGER>(sql0.size())));
549549

550550
SQLWCHAR sql_state[6] = {0};
551551
SQLINTEGER native_error = 0;
552-
SQLWCHAR message[SQL_MAX_MESSAGE_LENGTH] = {0};
553552
SQLSMALLINT message_length = 0;
554-
ASSERT_EQ(SQL_SUCCESS, SQLError(nullptr, nullptr, this->stmt, sql_state, &native_error,
553+
SQLWCHAR message[SQL_MAX_MESSAGE_LENGTH] = {0};
554+
ASSERT_EQ(SQL_SUCCESS, SQLError(SQL_NULL_HENV, this->conn, this->stmt, sql_state, &native_error,
555555
message, SQL_MAX_MESSAGE_LENGTH, &message_length));
556-
557556
EXPECT_GT(message_length, 70);
558557

559558
EXPECT_EQ(100, native_error);

0 commit comments

Comments
 (0)