Skip to content

Commit d1a4701

Browse files
authored
Allow content-type header (#69)
1 parent 6f27af1 commit d1a4701

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
SHELL = /bin/sh
22

3-
VERSION=1.7.0
3+
VERSION=1.7.1
44
BUILD=`git rev-parse HEAD`
55

66
LDFLAGS=-ldflags "-w -s \

fakeserver/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func loggingMiddleware(next http.Handler) http.Handler {
3535
func createCors() *cors.Cors {
3636
return cors.New(cors.Options{
3737
AllowCredentials: true,
38-
AllowedHeaders: []string{"authorization"},
38+
AllowedHeaders: []string{"*"},
3939
AllowOriginFunc: func(origin string) bool {
4040
allowedOrigins, ok := os.LookupEnv("TESTTRACK_ALLOWED_ORIGINS")
4141
if ok {

fakeserver/server_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,22 @@ func TestCors(t *testing.T) {
271271
require.Equal(t, "http://127.0.0.1:3000", w.Result().Header.Get("Access-Control-Allow-Origin"))
272272
})
273273

274+
t.Run("it allows multiple headers in preflight request", func(t *testing.T) {
275+
w := httptest.NewRecorder()
276+
h := createHandler()
277+
278+
request := httptest.NewRequest("OPTIONS", "/api/v2/split_registry", nil)
279+
request.Header.Add("Origin", "http://www.allowed.com")
280+
request.Header.Add("Access-Control-Request-Method", "POST")
281+
request.Header.Add("Access-Control-Request-Headers", "content-type, authorization, accept")
282+
283+
h.ServeHTTP(w, request)
284+
285+
require.Equal(t, http.StatusNoContent, w.Code)
286+
require.Equal(t, "http://www.allowed.com", w.Result().Header.Get("Access-Control-Allow-Origin"))
287+
require.Equal(t, "content-type, authorization, accept", w.Result().Header.Get("Access-Control-Allow-Headers"))
288+
})
289+
274290
os.Unsetenv("TESTTRACK_ALLOWED_ORIGINS")
275291
}
276292

0 commit comments

Comments
 (0)