mocking test filename for lnbl file for tests

Author: David Zuckerman

docker-compose.ci.yml

@@ -2,7 +2,8 @@ services:
   app:
     build: !reset
     image: ${DOCKER_APP_IMAGE}
-    environment: !reset
+    environment: !override
+      - LBNL_FILENAME:test 
     entrypoint: ["tail", "-f", "/dev/null"] 
     volumes: !override
       - artifacts:/opt/app/artifacts

docker-compose.yml

@@ -8,6 +8,7 @@ services:
       LIT_GOBI_USERNAME: "${LIT_GOBI_USERNAME}"
       LIT_LBNL_KEY_DATA: "${LIT_LBNL_KEY_DATA}"
       LIT_LBNL_USERNAME: "${LIT_LBNL_USERNAME}"
+      LBNL_FILENAME: "${LBNL_FILENAME}"
     init: true 
     volumes:
       - ./:/opt/app

env.sample

@@ -2,3 +2,4 @@ LIT_GOBI_PASSWORD='password'
 LIT_GOBI_USERNAME='username'
 LIT_LBNL_KEY_DATA='ssh key'
 LIT_LBNL_USERNAME='username'
+LBNL_FILENAME='the base name for the lbnl file'

lib/berkeley_library/sftp_handler/downloader/lbnl.rb

@@ -5,7 +5,7 @@
 module BerkeleyLibrary
   module SftpHandler
     module Downloader
-      # Downloads the latest lbnl_people_yyyymmdd.zip patron file.
+      # Downloads the latest ${LBNL_FILENAME}_yyyymmdd.zip patron file.
       #
       # LBNL seems to populate this every Monday, so by default the class looks for the file
       # that would've been added on the most recent Monday. If today is Monday, it uses today's

spec/downloader/lbnl_spec.rb

@@ -9,8 +9,8 @@
 
   describe '#download!' do
     let(:now) { Time.new(2022, 5, 25, 0, 0, 0) }
-    let(:last_weeks_filename) { 'lbnl_people_20220516.zip' }
-    let(:this_weeks_filename) { 'lbnl_people_20220523.zip' }
+    let(:last_weeks_filename) { 'test_20220516.zip' }
+    let(:this_weeks_filename) { 'test_20220523.zip' }
     let(:todays_remote_path) { Pathname.new(this_weeks_filename) }
     let(:sftp_session) { instance_double(Net::SFTP::Session) }
 
@@ -44,7 +44,7 @@
     end
 
     it 'downloads a specific file' do
-      filename = 'lbnl_people_20220516.zip'
+      filename = 'test_20220516.zip'
       remote_path = Pathname.new(filename)
       local_path = Pathname.new("/opt/app/data/#{filename}")
 
@@ -76,31 +76,31 @@
     context 'on Sunday May 29, 2022' do
       its(:default_filename) do
         Timecop.freeze(Time.new(2022, 5, 29, 23, 59, 59)) do
-          is_expected.to eq 'lbnl_people_20220523.zip'
+          is_expected.to eq 'test_20220523.zip'
         end
       end
     end
 
     context 'on Monday May 30, 2022' do
       its(:default_filename) do
         Timecop.freeze(Time.new(2022, 5, 30, 23, 59, 59)) do
-          is_expected.to eq 'lbnl_people_20220530.zip'
+          is_expected.to eq 'test_20220530.zip'
         end
       end
     end
 
     context 'on Tuesday May 31, 2022' do
       its(:default_filename) do
         Timecop.freeze(Time.new(2022, 5, 31, 0, 0, 0)) do
-          is_expected.to eq 'lbnl_people_20220530.zip'
+          is_expected.to eq 'test_20220530.zip'
         end
       end
     end
 
     context 'on Wednesday May 25, 2022' do
       its(:default_filename) do
         Timecop.freeze(Time.new(2022, 5, 25, 23, 59, 59)) do
-          is_expected.to eq 'lbnl_people_20220523.zip'
+          is_expected.to eq 'test_20220523.zip'
         end
       end
     end