BibliographicJob: Improve failure handling

awilfox · awilfox · commit cc61417865ac · 2026-07-16T18:39:10.000-05:00
* Return the currently-processing host_bib on failure, when available.

* Separate the failure into its own mailer, and ensure the template
  includes both the failing text file and, if available, the specific
  MMS ID that failed.

* Report that information to the error logger as well.

* Amend tests to cover this new functionality.

Closes: AP-778
diff --git a/app/jobs/bibliographic_job.rb b/app/jobs/bibliographic_job.rb
@@ -2,12 +2,14 @@ class BibliographicJob < ApplicationJob
   queue_as :default
 
   def perform(host_bib_task)
+    current = nil
     host_bib_task.host_bibs.where(marc_status: %w[pending retrieving]).find_each do |host_bib|
+      current = host_bib
       Bibliographic::HostBib.create_linked_bibs(host_bib)
     end
     after_perform_upload!(host_bib_task)
   rescue StandardError => e
-    mark_failed_and_notify!(e, host_bib_task)
+    mark_failed_and_notify!(e, host_bib_task, current)
   end
 
   private
@@ -25,12 +27,13 @@ def generate_attatchments(host_bib_task)
     attachment_hash
   end
 
-  def mark_failed_and_notify!(e, host_bib_task)
+  def mark_failed_and_notify!(e, host_bib_task, host_bib)
     host_bib_task.failed!
     subject = 'Host Bibliographic Upload - Failed'
-    message = 'Host Bibliographic upload failed, please reach out to our support team.'
-    RequestMailer.bibliographic_email(host_bib_task.email, [], subject, message).deliver_now
-    logger.error "BibliographicJob failed: #{e.message}"
+    RequestMailer.bibliographic_failure_email(host_bib_task.email, subject, host_bib_task, host_bib).deliver_now
+    mms_id = host_bib&.mms_id
+    filename = File.basename(host_bib_task.filename)
+    logger.error "BibliographicJob failed processing #{mms_id} in #{filename}: #{e.message}"
     raise e
   end
 
diff --git a/app/mailers/request_mailer.rb b/app/mailers/request_mailer.rb
@@ -232,6 +232,12 @@ def bibliographic_email(email, attachment_contents, subject, body)
     mail(to: email, subject:, body:)
   end
 
+  def bibliographic_failure_email(email, subject, host_bib_task, host_bib)
+    @host_bib_task = host_bib_task
+    @host_bib = host_bib
+    mail(to: email, subject:)
+  end
+
   def efee_invoice_email(alma_id)
     efee = EfeesInvoice.new(alma_id)
     # type probably isn't needed now that I spun this off to a separate url
diff --git a/app/views/request_mailer/bibliographic_failure_email.html.erb b/app/views/request_mailer/bibliographic_failure_email.html.erb
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta content='text/html; charset=UTF-8' http-equiv='Content-Type' />
+  </head>
+
+  <body>
+  <br/>
+  <h1>Upload Failed</h1>
+  Your Host Bibliographic upload failed.  Please reach out to our support team.
+
+  <h2>Details</h2>
+  <dl>
+    <% if @host_bib_task %>
+    <dt>Failing file</dt>
+    <dd><%= File.basename(@host_bib_task.filename) %></dd>
+    <% end %>
+    <% if @host_bib %>
+    <dt>Failing Host MMS ID</dt>
+    <dd><%= @host_bib.mms_id %></dd>
+    <% end %>
+  </dl>
+  </body>
+</html>
diff --git a/app/views/request_mailer/bibliographic_failure_email.text.erb b/app/views/request_mailer/bibliographic_failure_email.text.erb
@@ -0,0 +1,10 @@
+Your Host Bibliographic upload failed.  Please reach out to our support team.
+
+Failure details:
+
+<% if @host_bib_task %>
+Failing file: <%= File.basename(@host_bib_task.filename) %>
+<% end %>
+<% if @host_bib %>
+Failing Host MMS ID: <%= @host_bib.mms_id %>
+<% end %>
diff --git a/spec/jobs/bibliographic_job_spec.rb b/spec/jobs/bibliographic_job_spec.rb
@@ -73,12 +73,12 @@
           .and_raise(StandardError.new('Error'))
 
         expect(RequestMailer)
-          .to receive(:bibliographic_email)
+          .to receive(:bibliographic_failure_email)
           .with(
             email,
-            [],
             'Host Bibliographic Upload - Failed',
-            'Host Bibliographic upload failed, please reach out to our support team.'
+            host_bib_task,
+            host_bib
           ).and_return(mailer_double)
 
         expect { BibliographicJob.perform_now(host_bib_task) }.to raise_error(StandardError)
