Remove unneeded db lookup for tabcomplete on startup

Author: BenCodez

AdvancedCore/src/main/java/com/bencodez/advancedcore/AdvancedCorePlugin.java

@@ -577,31 +577,8 @@ public void loadTabComplete() {
 			public void reload() {
 				ArrayList<String> players = new ArrayList<>();
 
-				// Prefer UUIDs from storage; names come from UuidLookup cache (seeded at
-				// startup)
-				for (String uuid : getUserManager().getAllUUIDs()) {
-					String name = UuidLookup.getInstance().getCachedName(uuid);
-					if (name == null || name.isEmpty()) {
-						// Fallback: try to read from user data without DB lookup
-						try {
-							AdvancedCoreUser user = getUserManager().getUser(UUID.fromString(uuid), false);
-							if (user != null) {
-								String stored = user.getData().getString("PlayerName", UserDataFetchMode.NO_DB_LOOKUP);
-								if (stored != null && !stored.isEmpty()
-										&& !stored.equalsIgnoreCase("Error getting name")
-										&& !stored.equalsIgnoreCase("null")) {
-									UuidLookup.getInstance().cacheMapping(uuid, stored);
-									name = stored;
-								}
-							}
-						} catch (Exception ignored) {
-						}
-					}
-
-					if (name != null && !name.isEmpty() && !players.contains(name)) {
-						players.add(name);
-					}
-				}
+				// fetch all cached names; this avoids hitting the DB
+				players.addAll(UuidLookup.getInstance().getAllCachedNames());
 
 				// Always include currently online players
 				for (Player p : Bukkit.getOnlinePlayers()) {
@@ -615,6 +592,7 @@ public void reload() {
 
 			@Override
 			public void updateReplacements() {
+				// ensure new online players are added to the replacement list
 				for (Player player : Bukkit.getOnlinePlayers()) {
 					if (!getReplace().contains(player.getName())) {
 						getReplace().add(player.getName());

AdvancedCore/src/main/java/com/bencodez/advancedcore/api/player/UuidLookup.java

@@ -1,6 +1,8 @@
 package com.bencodez.advancedcore.api.player;
 
 import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Locale;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
@@ -31,6 +33,19 @@ public static UuidLookup getInstance() {
 	private UuidLookup() {
 		// Cache is owned here.
 	}
+	
+	/**
+	 * Retrieve all player names currently cached in memory.
+	 *
+	 * <p>This returns a snapshot of the internal uuid→name map values. It does not
+	 * hit any storage, so it’s safe to call from tab‑complete code.</p>
+	 *
+	 * @return list containing all cached player names (may include duplicates)
+	 */
+	public List<String> getAllCachedNames() {
+	    return new ArrayList<>(uuidToName.values());
+	}
+
 
 	/*
 	 * ========================= Public API =========================