Skip to content

Commit 275bd1d

Browse files
committed
fixed a mistake with pipeline asset
1 parent d3bb593 commit 275bd1d

21 files changed

Lines changed: 3279 additions & 460 deletions

File tree

Basis/Assets/AddressableAssetsData/link.xml

Lines changed: 0 additions & 385 deletions
This file was deleted.

Basis/Assets/AddressableAssetsData/link.xml.meta

Lines changed: 0 additions & 7 deletions
This file was deleted.

Basis/Assets/Basis/Settings/Quality Settiings/Modified - Quest.asset renamed to Basis/Assets/Basis/Settings/Quality Settiings/Modified - Android.asset

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ MonoBehaviour:
1010
m_Enabled: 1
1111
m_EditorHideFlags: 0
1212
m_Script: {fileID: 11500000, guid: bf2edee5c58d82540a51f03df9d42094, type: 3}
13-
m_Name: Modified - Quest
13+
m_Name: Modified - Android
1414
m_EditorClassIdentifier:
1515
k_AssetVersion: 13
1616
k_AssetPreviousVersion: 13

Basis/Assets/Basis/Settings/Quality Settiings/Modified - Quest.asset.meta renamed to Basis/Assets/Basis/Settings/Quality Settiings/Modified - Android.asset.meta

File renamed without changes.

Basis/Packages/com.basis.framework/BasisUI/BasisMenuMover.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,16 @@ private void OnBootModeChanged(string obj)
111111
{
112112
SetRootMode(GetFindCurrentMode());
113113
}
114-
115114
public void OnAvatarHeightChange()
116115
{
117116
SetRootMode(GetFindCurrentMode());
118117
}
119118

119+
public void OnAvatarHeightChange(BasisHeightDriver.HeightModeChange HeightModeChange)
120+
{
121+
SetRootMode(GetFindCurrentMode());
122+
}
123+
120124
public PanelGroupRootMode GetFindCurrentMode()
121125
{
122126
if (BasisDeviceManagement.IsUserInDesktop())

Basis/Packages/com.basis.framework/BasisUI/Menus/BasisMainMenu.cs

Lines changed: 30 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ public static string ActiveMenuTitle
1111
{
1212
get
1313
{
14-
if (!Instance || !Instance.ActiveMenu) return string.Empty;
14+
if (!Instance || !Instance.ActiveMenu)
15+
{
16+
return string.Empty;
17+
}
18+
1519
return Instance.ActiveMenu.Data.Title;
1620
}
1721
}
@@ -23,13 +27,9 @@ public static string ActiveMenuTitle
2327

2428
public BasisMainMenu()
2529
{
26-
HotbarMenu = BasisMenuPanel.CreateNew(
27-
BasisMenuPanel.PanelData.Toolbar(MenuTitle),
28-
MenuObjectInstance.PanelRoot);
30+
HotbarMenu = BasisMenuPanel.CreateNew(BasisMenuPanel.PanelData.Toolbar(MenuTitle), MenuObjectInstance.PanelRoot);
2931

30-
HorizontalLayout = PanelElementDescriptor.CreateNew(
31-
PanelElementDescriptor.ElementStyles.ScrollViewHorizontal,
32-
HotbarMenu.Descriptor.ContentParent);
32+
HorizontalLayout = PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.ScrollViewHorizontal, HotbarMenu.Descriptor.ContentParent);
3333

3434
BindProvidersToButtons();
3535
}
@@ -38,20 +38,34 @@ public static void Open()
3838
{
3939
BasisUIManagement.CloseAllMenus();
4040

41-
if (Instance) Instance.Release();
41+
if (Instance)
42+
{
43+
Instance.Release();
44+
}
45+
4246
Instance = new BasisMainMenu();
4347
BasisCursorManagement.UnlockCursor(nameof(BasisMainMenu));
4448
}
4549

4650
public static void Toggle()
4751
{
48-
if (Instance) Close();
49-
else Open();
52+
if (Instance)
53+
{
54+
Close();
55+
}
56+
else
57+
{
58+
Open();
59+
}
5060
}
5161

5262
public static void Close()
5363
{
54-
if (!Instance) return;
64+
if (!Instance)
65+
{
66+
return;
67+
}
68+
5569
Instance.Release();
5670
Instance = null;
5771
BasisCursorManagement.LockCursor(nameof(BasisMainMenu));
@@ -66,15 +80,16 @@ public static BasisMenuPanel CreateActiveMenu(BasisMenuPanel.PanelData data, str
6680
if (Instance.ActiveMenu)
6781
{
6882
if (Instance.ActiveMenu.Data.Title == data.Title)
83+
{
6984
return Instance.ActiveMenu;
85+
}
7086
else
87+
{
7188
Instance.ActiveMenu.ReleaseInstance();
89+
}
7290
}
7391

74-
Instance.ActiveMenu = BasisMenuPanel.CreateNew(
75-
data,
76-
Instance.MenuObjectInstance.PanelRoot,
77-
style);
92+
Instance.ActiveMenu = BasisMenuPanel.CreateNew( data, Instance.MenuObjectInstance.PanelRoot, style);
7893
return Instance.ActiveMenu;
7994
}
8095
}

Basis/Packages/com.basis.framework/Camera/BasisHandHeldCameraInteractable.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ private void OnInteractDesktopTweak(BasisInput _input)
192192
}
193193

194194
/// <summary>Rescales the camera when the local player’s avatar height changes.</summary>
195-
private void OnHeightChanged()
195+
private void OnHeightChanged(BasisHeightDriver.HeightModeChange HeightModeChange)
196196
{
197197
transform.localScale = new Vector3(cameraDefaultScale, cameraDefaultScale, cameraDefaultScale) * BasisHeightDriver.ScaledToMatchValue;
198198
}

Basis/Packages/com.basis.framework/Device Management/Common/BasisVisualTracker.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using Basis.Scripts.Device_Management.Devices;
33
using System;
44
using UnityEngine;
5+
using static BasisHeightDriver;
56

67
namespace Basis.Scripts.Device_Management
78
{
@@ -49,12 +50,12 @@ public void Initialization(BasisInput basisInput)
4950
{
5051
BasisInput = basisInput;
5152

52-
UpdateVisualSizeAndOffset();
53+
OnPlayersHeightChangedNextFrame();
5354

5455
if (HasEvents == false)
5556
{
56-
BasisLocalPlayer.OnLocalAvatarChanged += UpdateVisualSizeAndOffset;
57-
BasisLocalPlayer.OnPlayersHeightChangedNextFrame += UpdateVisualSizeAndOffset;
57+
BasisLocalPlayer.OnLocalAvatarChanged += OnPlayersHeightChangedNextFrame;
58+
BasisLocalPlayer.OnPlayersHeightChangedNextFrame += OnPlayersHeightChangedNextFrame;
5859
HasEvents = true;
5960
}
6061

@@ -69,17 +70,19 @@ public void OnDestroy()
6970
{
7071
if (HasEvents)
7172
{
72-
BasisLocalPlayer.OnLocalAvatarChanged -= UpdateVisualSizeAndOffset;
73-
BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= UpdateVisualSizeAndOffset;
73+
BasisLocalPlayer.OnLocalAvatarChanged -= OnPlayersHeightChangedNextFrame;
74+
BasisLocalPlayer.OnPlayersHeightChangedNextFrame -= OnPlayersHeightChangedNextFrame;
7475
HasEvents = false;
7576
}
7677
}
77-
78+
public void OnPlayersHeightChangedNextFrame()
79+
{
80+
}
7881
/// <summary>
7982
/// Applies avatar-relative scale and local offset/rotation to the visual.
8083
/// Called on initialization and whenever the local avatar/height changes.
8184
/// </summary>
82-
public void UpdateVisualSizeAndOffset()
85+
public void OnPlayersHeightChangedNextFrame(HeightModeChange Mode)
8386
{
8487
this.transform.localScale = ScaleOfModel * BasisHeightDriver.AvatarToDefaultRatioScaled;
8588
this.transform.SetLocalPositionAndRotation(Vector3.zero, ModelRotationOffset);

Basis/Packages/com.basis.framework/Drivers/Common/BasisHeightDriver.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,14 @@ public static void ApplyScale(bool ScaleAvatar, float SelectedScale)
8989
// Notify next frame so listeners read consistent updated values.
9090
BasisLocalPlayer.Instance.ExecuteNextFrame(() =>
9191
{
92-
BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke();
92+
BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke(HeightModeChange.ScaleOnly);
9393
});
9494
}
95-
95+
public enum HeightModeChange
96+
{
97+
ScaleOnly,
98+
ScaleAndMode
99+
}
96100
/// <summary>
97101
/// Applies a scale factor to the local avatar and updates any cached bone offsets
98102
/// that must remain consistent with the avatar's scale.
@@ -195,7 +199,7 @@ public static void CaptureAvatarHeightDuringTpose()
195199
// Notify next frame so listeners read consistent updated values.
196200
BasisLocalPlayer.Instance.ExecuteNextFrame(() =>
197201
{
198-
BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke();
202+
BasisLocalPlayer.OnPlayersHeightChangedNextFrame?.Invoke(HeightModeChange.ScaleAndMode);
199203
});
200204
}
201205

Basis/Packages/com.basis.framework/Drivers/Local/BasisLocalCameraDriver.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ private void OnModeSwitch(string mode)
256256
{
257257
Camera.fieldOfView = DefaultCameraFov;
258258
}
259-
UpdateCameraScale();
259+
UpdateCameraScale(BasisHeightDriver.HeightModeChange.ScaleAndMode);
260260
}
261261

262262
/// <summary>
@@ -281,13 +281,16 @@ public void SetDesiredClipPlanes(float clipFar, float clipNear)
281281
{
282282
DesiredClipFar = clipFar;
283283
DesiredClipNear = clipNear;
284-
UpdateCameraScale();
284+
UpdateCameraScale(BasisHeightDriver.HeightModeChange.ScaleAndMode);
285+
}
286+
private void UpdateCameraScale()
287+
{
288+
UpdateCameraScale(BasisHeightDriver.HeightModeChange.ScaleAndMode);
285289
}
286-
287290
/// <summary>
288291
/// Applies scale from the player's height so the camera’s local scale matches avatar scale.
289292
/// </summary>
290-
public void UpdateCameraScale()
293+
public void UpdateCameraScale(BasisHeightDriver.HeightModeChange HeightModeChange)
291294
{
292295
this.transform.localScale = Vector3.one * BasisHeightDriver.DeviceScale;
293296
// Ensure that the near clip plane is never far enough away that the avatar body clips through it.

0 commit comments

Comments
 (0)