Merge pull request #56 from Basekick-Labs/perf/hasnilcode-inline

xe-nvdk · web-flow · commit 5f6d4fe0901d · 2026-03-02T19:44:19.000-06:00
perf(decode): inline hasNilCode for byte-slice reader
diff --git a/decode.go b/decode.go
@@ -624,6 +624,11 @@ func (d *Decoder) ReadFull(buf []byte) error {
 }
 
 func (d *Decoder) hasNilCode() bool {
+	// Fast path: when decoding from a byte slice, peek directly
+	// to avoid two interface method calls (ReadByte + UnreadByte).
+	if d.s == &d.bsr {
+		return d.bsr.pos < len(d.bsr.data) && d.bsr.data[d.bsr.pos] == msgpcode.Nil
+	}
 	code, err := d.PeekCode()
 	return err == nil && code == msgpcode.Nil
 }

Original file line number	Diff line number	Diff line change
`@@ -624,6 +624,11 @@ func (d *Decoder) ReadFull(buf []byte) error {`
`624`	`624`	`}`
`625`	`625`
`626`	`626`	`func (d *Decoder) hasNilCode() bool {`
	`627`	`+ // Fast path: when decoding from a byte slice, peek directly`
	`628`	`+ // to avoid two interface method calls (ReadByte + UnreadByte).`
	`629`	`+ if d.s == &d.bsr {`
	`630`	`+ return d.bsr.pos < len(d.bsr.data) && d.bsr.data[d.bsr.pos] == msgpcode.Nil`
	`631`	`+ }`
`627`	`632`	`code, err := d.PeekCode()`
`628`	`633`	`return err == nil && code == msgpcode.Nil`
`629`	`634`	`}`