Fixed various warnings.

Author: Azzinoth

VisualNode.cpp

@@ -224,7 +224,7 @@ bool Node::FromJson(Json::Value Json)
 		Input[i] = nullptr;
 	}
 
-	std::pair<int, int> SocketCountInClassDefinition = NODE_FACTORY.GetSocketCount(Type);
+	std::pair<size_t, size_t> SocketCountInClassDefinition = NODE_FACTORY.GetSocketCount(Type);
 	Input.resize(InputsList.size());
 
 	// Validate if the number of input sockets in the JSON data matches the current class definition.
@@ -306,6 +306,8 @@ bool Node::FromJson(Json::Value Json)
 		Output[i] = new NodeSocket(this, Type, Name, true);
 		Output[i]->ID = ID;
 	}
+
+	return true;
 }
 
 void Node::UpdateClientRegion()

VisualNodeFactory.cpp

@@ -46,7 +46,7 @@ Node* NodeFactory::CopyNode(const std::string& Type, const Node& Node) const
     return CopyConstructorIterator->second(Node);
 }
 
-std::pair<int, int> NodeFactory::GetSocketCount(std::string NodeClassName)
+std::pair<size_t, size_t> NodeFactory::GetSocketCount(std::string NodeClassName)
 {
 	auto NodeClassNameToSocketCountIterator = NodeClassNameToSocketCount.find(NodeClassName);
 	if (NodeClassNameToSocketCountIterator != NodeClassNameToSocketCount.end())
@@ -58,15 +58,15 @@ std::pair<int, int> NodeFactory::GetSocketCount(std::string NodeClassName)
 		Node* TemporaryNode = CreateNode(NodeClassName);
 		if (TemporaryNode != nullptr)
 		{
-			int InputCount = TemporaryNode->GetInputSocketCount();
-			int OutputCount = TemporaryNode->GetOutputSocketCount();
-			NodeClassNameToSocketCount[NodeClassName] = std::pair<int, int>(InputCount, OutputCount);
+			size_t InputCount = TemporaryNode->GetInputSocketCount();
+			size_t OutputCount = TemporaryNode->GetOutputSocketCount();
+			NodeClassNameToSocketCount[NodeClassName] = std::pair<size_t, size_t>(InputCount, OutputCount);
 			delete TemporaryNode;
-			return std::pair<int, int>(InputCount, OutputCount);
+			return std::pair<size_t, size_t>(InputCount, OutputCount);
 		}
 		else
 		{
-			return std::pair<int, int>(0, 0);
+			return std::pair<size_t, size_t>(0, 0);
 		}
 	}
 }

VisualNodeFactory.h

@@ -13,14 +13,14 @@ namespace VisNodeSys
         std::unordered_map<std::string, std::function<Node* ()>> Constructors;
         std::unordered_map<std::string, std::function<Node* (const Node&)>> CopyConstructors;
 
-        std::unordered_map<std::string, std::pair<int, int>> NodeClassNameToSocketCount;
+        std::unordered_map<std::string, std::pair<size_t, size_t>> NodeClassNameToSocketCount;
         // Retrieves the expected number of input and output sockets for a given node type,
         // as defined by its current C++ class implementation.
         // It is used to validate loaded node data (e.g., from a JSON file)
         // If a node class's socket structure(number of inputs / outputs) has changed since a file was saved,
         // loading that file could lead to inconsistencies or crashes.
 		// TO-DO: Implement a more robust NodeClass integrity check. With socket type validation and more.
-        std::pair<int, int> GetSocketCount(std::string NodeClassName);
+        std::pair<size_t, size_t> GetSocketCount(std::string NodeClassName);
     public:
         SINGLETON_PUBLIC_PART(NodeFactory)