From 056129cd38b2fabda77c8e04b60743bc4535a7e8 Mon Sep 17 00:00:00 2001 From: Shahzaib Date: Tue, 21 Jul 2026 14:11:36 -0700 Subject: [PATCH] Remove ADAL service tree from S360 Reporter skill We no longer monitor the AuthN SDK - ADAL Android service tree (937cdc57-1253-4b55-878e-5854368926a2). Removed it from DEFAULT_SERVICE_IDS and tenant patterns in merge-items.js, the Target Services table and query examples in SKILL.md, and the report header service chips in generate-report.js and report-template.md. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 84aa6694-5d85-4319-a0ca-41ba459894e7 --- .github/skills/s360-reporter/SKILL.md | 10 ++++------ .github/skills/s360-reporter/generate-report.js | 2 +- .github/skills/s360-reporter/merge-items.js | 5 ++--- .github/skills/s360-reporter/report-template.md | 2 +- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/skills/s360-reporter/SKILL.md b/.github/skills/s360-reporter/SKILL.md index 198e1d82..72a00315 100644 --- a/.github/skills/s360-reporter/SKILL.md +++ b/.github/skills/s360-reporter/SKILL.md @@ -42,7 +42,6 @@ Skip PBI creation, report generation, and email drafting in quick mode. | Service | Service Tree ID | |---------|----------------| -| AuthN SDK - ADAL Android | `937cdc57-1253-4b55-878e-5854368926a2` | | AuthN SDK - MSAL Android | `8d0d308e-cd5c-44a3-9518-43eeeb424b57` | | Microsoft Authenticator - Android | `0b97f26e-fcfc-4ed1-95e9-1dca3a2fde3b` | @@ -128,13 +127,12 @@ Fetch items from **two sources** and merge them: #### 1a: Service-targeted items -Call `mcp_s360-breeze-m_search_active_s360_kpi_action_items` with all three service tree IDs: +Call `mcp_s360-breeze-m_search_active_s360_kpi_action_items` with both service tree IDs: ``` request: { "pageSize": 50, "targetIds": [ - "937cdc57-1253-4b55-878e-5854368926a2", "8d0d308e-cd5c-44a3-9518-43eeeb424b57", "0b97f26e-fcfc-4ed1-95e9-1dca3a2fde3b" ] @@ -162,8 +160,8 @@ that are tied to individuals rather than service tree IDs. including items from other team memberships. After fetching, filter results to only include items where one of these conditions is met: - `TargetType` is `"Person"` AND `TargetId` exactly matches one of the team aliases -- `TargetId` matches one of our three service tree IDs -- `CustomDimensions.TenantName` contains "Auth Client", "MSAL", "ADAL", or "Authenticator" +- `TargetId` matches one of our two service tree IDs +- `CustomDimensions.TenantName` contains "Auth Client", "MSAL", or "Authenticator" **Critical — do NOT expand group items**: Each S360 item has exactly one `AssignedTo` and one `TargetId`. Treat each item as-is — one row per `KpiActionItemId`. Never split @@ -200,7 +198,7 @@ inputs. **Filter logic** (enforced by the script — do not duplicate ad-hoc): - `TargetType == "Person"` AND `TargetId` is a team alias → keep -- `TargetId` is one of the three service tree GUIDs → keep +- `TargetId` is one of the two service tree GUIDs → keep - `CustomDimensions.TenantName` matches an Auth-team pattern → keep - **`AssignedTo` alone is NOT sufficient** — the person query already filters by `assignedTo`, so every returned item has a team-alias `AssignedTo` but many are diff --git a/.github/skills/s360-reporter/generate-report.js b/.github/skills/s360-reporter/generate-report.js index 664f7131..81bba315 100644 --- a/.github/skills/s360-reporter/generate-report.js +++ b/.github/skills/s360-reporter/generate-report.js @@ -172,7 +172,7 @@ html += `

- Services: AuthN SDK - MSAL Android • AuthN SDK - ADAL Android • Microsoft Authenticator - Android + Services: AuthN SDK - MSAL Android • Microsoft Authenticator - Android

`; diff --git a/.github/skills/s360-reporter/merge-items.js b/.github/skills/s360-reporter/merge-items.js index 419d1699..323400e1 100644 --- a/.github/skills/s360-reporter/merge-items.js +++ b/.github/skills/s360-reporter/merge-items.js @@ -18,7 +18,7 @@ // // Inputs: // --service Raw response from search_active_s360_kpi_action_items keyed by -// targetIds (the 3 Android Auth service tree GUIDs). +// targetIds (the 2 Android Auth service tree GUIDs). // --person Raw response from the same tool keyed by assignedTo (team // aliases). // --team JSON file: { aliases, nameMap, serviceIds?, tenantPatterns? }. @@ -42,11 +42,10 @@ const path = require('path'); // ── Defaults ────────────────────────────────────────────────────────────────── const DEFAULT_SERVICE_IDS = [ - '937cdc57-1253-4b55-878e-5854368926a2', // AuthN SDK - ADAL Android '8d0d308e-cd5c-44a3-9518-43eeeb424b57', // AuthN SDK - MSAL Android '0b97f26e-fcfc-4ed1-95e9-1dca3a2fde3b' // Microsoft Authenticator - Android ]; -const DEFAULT_TENANT_PATTERNS = ['auth client', 'msal', 'adal', 'authenticator']; +const DEFAULT_TENANT_PATTERNS = ['auth client', 'msal', 'authenticator']; // ── CLI args ────────────────────────────────────────────────────────────────── function getArg(name) { diff --git a/.github/skills/s360-reporter/report-template.md b/.github/skills/s360-reporter/report-template.md index 7d0e6133..b264ea32 100644 --- a/.github/skills/s360-reporter/report-template.md +++ b/.github/skills/s360-reporter/report-template.md @@ -94,7 +94,7 @@ Blue top bar + uppercase label + team name + blue date pill + services line.

- Services: AuthN SDK - MSAL Android • AuthN SDK - ADAL Android • Microsoft Authenticator - Android + Services: AuthN SDK - MSAL Android • Microsoft Authenticator - Android