Constants/RestrictedConstants: use PHPCSUtils TextStrings::stripQuotes()

... to only strip the wrapping quotes and not remove any quotes inside the wrapping quotes, which are part of the actual text string.

Includes test.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Constants/RestrictedConstantsSniff.php

@@ -10,6 +10,7 @@
 namespace WordPressVIPMinimum\Sniffs\Constants;
 
 use PHP_CodeSniffer\Util\Tokens;
+use PHPCSUtils\Utils\TextStrings;
 use WordPressVIPMinimum\Sniffs\Sniff;
 
 /**
@@ -87,7 +88,7 @@ public function process_token( $stackPtr ) {
 		if ( $this->tokens[ $stackPtr ]['code'] === T_STRING ) {
 			$constantName = $this->tokens[ $stackPtr ]['content'];
 		} else {
-			$constantName = trim( $this->tokens[ $stackPtr ]['content'], "\"'" );
+			$constantName = TextStrings::stripQuotes( $this->tokens[ $stackPtr ]['content'] );
 		}
 
 		if ( isset( $this->restrictedConstants[ $constantName ] ) === false

WordPressVIPMinimum/Tests/Constants/RestrictedConstantsUnitTest.inc

@@ -20,4 +20,6 @@ if ( defined( 'JETPACK_DEV_DEBUG' ) ) { // Okay. Can touch.
 
 if ( constant( 'WP_CRON_CONTROL_SECRET' ) ) { // Okay. Can touch.
 
-}
+}
+
+define( '"A8C_PROXIED_REQUEST"', false ); // Okay, well not really as the name is not a valid PHP constant name, but that's not our concern.