Skip to content

Commit 5332560

Browse files
authored
Fix mobile web layout for track tiles (#13595)
Drop artist-pick UI for mobile-web track tiles (too small) Fixes mobile-web play-bar overflow
1 parent 69a8a9b commit 5332560

3 files changed

Lines changed: 29 additions & 28 deletions

File tree

packages/web/src/components/play-bar/mobile/PlayBar.module.css

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,40 +47,44 @@
4747
}
4848

4949
.info {
50-
flex: 1 1;
50+
flex: 1 1 auto;
5151
display: flex;
5252
align-items: center;
5353
cursor: pointer;
5454
height: 100%;
55-
width: 100%;
55+
min-width: 0;
5656
margin-right: var(--harmony-unit-2);
5757
user-select: none;
5858
padding-top: 20px;
5959
margin-top: -20px;
6060
}
6161

62-
.separator {
63-
margin: 0px 4px;
62+
.text {
63+
flex: 1 1 auto;
64+
min-width: 0;
65+
margin-left: 8px;
6466
}
6567

66-
.title {
67-
max-width: calc(66% - 23px);
68-
line-height: normal;
68+
.titleLine {
69+
display: block;
70+
min-width: 0;
6971
overflow: hidden;
7072
white-space: nowrap;
7173
text-overflow: ellipsis;
72-
margin-left: 8px;
74+
line-height: normal;
75+
}
76+
77+
.separator {
78+
margin: 0px 4px;
79+
}
80+
81+
.title {
7382
color: var(--harmony-neutral);
7483
font-size: var(--harmony-font-xs);
7584
font-weight: var(--harmony-font-bold);
7685
}
7786

7887
.artist {
79-
white-space: nowrap;
80-
overflow: hidden;
81-
text-overflow: ellipsis;
82-
line-height: normal;
83-
max-width: calc(33% - 12px);
8488
color: var(--harmony-neutral);
8589
font-size: var(--harmony-font-xs);
8690
font-weight: var(--harmony-font-medium);
@@ -90,11 +94,13 @@
9094
margin-left: auto;
9195
margin-right: 8px;
9296
justify-self: flex-end;
97+
flex: 0 0 auto;
9398
width: 32px;
9499
}
95100

96101
.lockPreview {
97-
margin-left: auto;
102+
flex: 0 0 auto;
103+
margin-left: var(--harmony-unit-2);
98104
}
99105

100106
.lockOverlay {

packages/web/src/components/play-bar/mobile/PlayBar.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,13 @@ const PlayBar = ({
177177
</div>
178178
</TrackFlair>
179179
) : null}
180-
<div className={styles.title}>{title}</div>
181-
<div className={styles.separator}></div>
182-
<div className={styles.artist}>{name}</div>
180+
<div className={styles.text}>
181+
<div className={styles.titleLine}>
182+
<span className={styles.title}>{title}</span>
183+
<span className={styles.separator}></span>
184+
<span className={styles.artist}>{name}</span>
185+
</div>
186+
</div>
183187
{shouldShowPreviewLock ? (
184188
<div className={styles.lockPreview}>
185189
<LockedStatusBadge

packages/web/src/components/track/mobile/TrackTile.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ import {
3535
Flex,
3636
Box,
3737
IconButton,
38-
IconKebabHorizontal,
39-
IconPin,
40-
IconText
38+
IconKebabHorizontal
4139
} from '@audius/harmony'
4240
import cn from 'classnames'
4341
import { useDispatch, useSelector } from 'react-redux'
@@ -103,8 +101,7 @@ export const TrackTile = ({
103101
containerClassName,
104102
isFeed = false,
105103
source,
106-
noShimmer,
107-
showArtistPick = false
104+
noShimmer
108105
}: ConnectedTrackTileProps) => {
109106
const dispatch = useDispatch()
110107

@@ -172,7 +169,6 @@ export const TrackTile = ({
172169
} = trackWithFallback
173170

174171
const isOwner = user_id === currentUserId
175-
const isArtistPick = partialUser?.artist_pick_track_id === track_id
176172

177173
const { isFetchingNFTAccess, hasStreamAccess } =
178174
useGatedContentAccess(trackWithFallback)
@@ -391,11 +387,6 @@ export const TrackTile = ({
391387
alignItems='center'
392388
className={cn(styles.duration, fadeIn)}
393389
>
394-
{showArtistPick && isArtistPick ? (
395-
<IconText icons={[{ icon: IconPin }]}>
396-
{messages.artistPick}
397-
</IconText>
398-
) : null}
399390
{duration
400391
? formatLineupTileDuration(
401392
duration,

0 commit comments

Comments
 (0)