fix: 定时任务创建失败时返回错误信息而非静默处理

Author: Hongbro886

astrbot/core/cron/manager.py

@@ -22,6 +22,11 @@
     from astrbot.core.star.context import Context
 
 
+class CronJobSchedulingError(Exception):
+    """Raised when a cron job fails to be scheduled."""
+    pass
+
+
 class CronJobManager:
     """Central scheduler for BasicCronJob and ActiveAgentCronJob."""
 
@@ -59,7 +64,10 @@ async def sync_from_db(self) -> None:
                     job.job_id,
                 )
                 continue
-            self._schedule_job(job)
+            try:
+                self._schedule_job(job)
+            except CronJobSchedulingError:
+                continue  # Error already logged in _schedule_job
 
     async def add_basic_job(
         self,
@@ -181,8 +189,9 @@ def _schedule_job(self, job: CronJob) -> None:
                     job.job_id, next_run_time=self._get_next_run_time(job.job_id)
                 )
             )
-        except Exception as e:
-            logger.error(f"Failed to schedule cron job {job.job_id}: {e!s}")
+        except (ValueError, TypeError) as e:
+            logger.exception("Failed to schedule cron job %s", job.job_id)
+            raise CronJobSchedulingError(str(e)) from e
 
     def _get_next_run_time(self, job_id: str):
         aps_job = self.scheduler.get_job(job_id)

astrbot/core/tools/cron_tools.py

@@ -7,6 +7,7 @@
 from astrbot.core.agent.run_context import ContextWrapper
 from astrbot.core.agent.tool import FunctionTool, ToolExecResult
 from astrbot.core.astr_agent_context import AstrAgentContext
+from astrbot.core.cron.manager import CronJobSchedulingError
 from astrbot.core.tools.registry import builtin_tool
 
 _CRON_TOOL_CONFIG = {
@@ -112,14 +113,17 @@ async def call(
                 "origin": "tool",
             }
 
-            job = await cron_mgr.add_active_job(
-                name=name,
-                cron_expression=str(cron_expression) if cron_expression else None,
-                payload=payload,
-                description=note,
-                run_once=run_once,
-                run_at=run_at_dt,
-            )
+            try:
+                job = await cron_mgr.add_active_job(
+                    name=name,
+                    cron_expression=str(cron_expression) if cron_expression else None,
+                    payload=payload,
+                    description=note,
+                    run_once=run_once,
+                    run_at=run_at_dt,
+                )
+            except CronJobSchedulingError:
+                return "error: failed to schedule task due to invalid configuration."
             next_run = job.next_run_time or run_at_dt
             suffix = (
                 f"one-time at {next_run}"
@@ -195,7 +199,10 @@ async def call(
             updates["cron_expression"] = cron_expression
             updates["payload"] = payload
 
-            job = await cron_mgr.update_job(str(job_id), **updates)
+            try:
+                job = await cron_mgr.update_job(str(job_id), **updates)
+            except CronJobSchedulingError:
+                return "error: failed to update task due to invalid configuration."
             if not job:
                 return f"error: cron job {job_id} not found."
             return f"Updated future task {job.job_id} ({job.name})."