Merge pull request #45 from AsBuiltReport/copilot/recommendations-and-improvements

Fix bugs and code quality issues across PowerShell module source files

Author: rebelinux

Src/Private/Get-AbrWinHyperVSummary.ps1

@@ -36,13 +36,13 @@ function Get-AbrWinHyperVSummary {
                         'VM Default Path' = $VmHost.VirtualMachinePath
                         'VM Disk Default Path' = $VmHost.VirtualHardDiskPath
                         'Supported VM Versions' = $VmHost.SupportedVmVersions -Join ","
-                        'Numa Spannning Enabled' = $VmHost.NumaSpanningEnabled
+                        'Numa Spanning Enabled' = $VmHost.NumaSpanningEnabled
                         'Iov Support' = $VmHost.IovSupport
                         'VM Migrations Enabled' = $VmHost.VirtualMachineMigrationEnabled
                         'Allow any network for Migrations' = $VmHost.UseAnyNetworkForMigration
                         'VM Migration Authentication Type' = $VmHost.VirtualMachineMigrationAuthenticationType
                         'Max Concurrent Storage Migrations' = $VmHost.MaximumStorageMigrations
-                        'Max Concurrent VM Migrations' = $VmHost.MaximumStorageMigrations
+                        'Max Concurrent VM Migrations' = $VmHost.MaximumVirtualMachineMigrations
                     }
                     $OutObj += [pscustomobject](ConvertTo-HashToYN $inObj)
 

Src/Private/Get-AbrWinIISWebSite.ps1

@@ -72,7 +72,7 @@ function Get-AbrWinIISWebSite {
                                                     'Name' = $IISWebSite.Name
                                                     'Auto Start' = $IISWebSite.serverAutoStart
                                                     'Enabled Protocols ' = $IISWebSite.enabledProtocols
-                                                    'URL' = Switch (($SiteURL.ResponseUri).count) {
+                                                    'URL' = Switch (($SiteURL.ResponseUri).Count) {
                                                         0 { "--" }
                                                         default { $SiteURL.ResponseUri }
                                                     }

Src/Private/Get-AbrWinLocalUser.ps1

@@ -36,7 +36,7 @@ function Get-AbrWinLocalUser {
                                     'User Name' = $LocalUser.Name
                                     'Description' = $LocalUser.Description
                                     'Account Enabled' = $LocalUser.Enabled
-                                    'Last Logon Date' = Switch (($LocalUser.LastLogon).count) {
+                                    'Last Logon Date' = Switch (($LocalUser.LastLogon).Count) {
                                         0 { "--" }
                                         default { $LocalUser.LastLogon.ToShortDateString() }
                                     }

Src/Private/Get-AbrWinOSConfig.ps1

@@ -21,7 +21,7 @@ function Get-AbrWinOSConfig {
 
     begin {
         Write-PScriboMessage "Operating System InfoLevel set at $($InfoLevel.OperatingSystem)."
-        Write-PScriboMessage "Collecting Oprating System Configuration information."
+        Write-PScriboMessage "Collecting Operating System Configuration information."
     }
 
     process {
@@ -36,7 +36,7 @@ function Get-AbrWinOSConfig {
                     'Windows Build Number' = $HostInfo.OsVersion
                     'Windows Install Type' = $HostInfo.WindowsInstallationType
                     'AD Domain' = $HostInfo.CsDomain
-                    'Windows Installation Date' = switch (($HostInfo.OsInstallDate).count) {
+                    'Windows Installation Date' = switch (($HostInfo.OsInstallDate).Count) {
                         0 { "--" }
                         default { $HostInfo.OsInstallDate.ToShortDateString() }
                     }

Src/Private/Get-AbrWinSMBNetworkInterface.ps1

@@ -35,7 +35,7 @@ function Get-AbrWinSMBNetworkInterface {
                         foreach ($SMBNIC in $SMBNICs) {
                             try {
                                 $inObj = [ordered] @{
-                                    'Name' = Switch (($SMBNIC.InterfaceIndex).count) {
+                                    'Name' = Switch (($SMBNIC.InterfaceIndex).Count) {
                                         0 { "Unknown" }
                                         default { Invoke-Command -Session $TempPssSession { (Get-NetAdapter -InterfaceIndex ($using:SMBNIC).InterfaceIndex).Name } }
                                     }

Src/Private/Get-RequiredFeature.ps1

@@ -15,9 +15,9 @@ function Get-RequiredFeature {
         The version of the required windows feature
     #>
 
+    [CmdletBinding()]
     Param
     (
-        [CmdletBinding()]
         [Parameter(Mandatory = $true, ValueFromPipeline = $false)]
         [ValidateNotNullOrEmpty()]
         [String]
@@ -30,11 +30,11 @@ function Get-RequiredFeature {
 
         [Parameter(Mandatory = $false, ValueFromPipeline = $false)]
         [Switch]
-        $Feature = $False,
+        $Feature,
 
         [Parameter(Mandatory = $false, ValueFromPipeline = $false)]
         [Switch]
-        $Status = $False,
+        $Status,
 
         [Parameter(Mandatory = $false, ValueFromPipeline = $false)]
         [ValidateNotNullOrEmpty()]

Src/Private/SharedUtilsFunctions.ps1

@@ -534,7 +534,7 @@ function ConvertTo-HashToYN {
 
     $result = [ordered] @{}
 
-    foreach ($i in $inObj.GetEnumerator()) {
+    foreach ($i in $TEXT.GetEnumerator()) {
         try {
             $valueToProcess = $i.Value
 
@@ -558,9 +558,6 @@ function ConvertTo-HashToYN {
     if ($result) {
         return $result
     } else {
-        # If $TEXT was empty or processing failed to produce results, return the original (empty) $TEXT
-        # Note: If $inObj was the source, and $TEXT is not used, this 'else' block might need review
-        # based on how $TEXT is intended to be used when $inObj is empty.
         return $TEXT
     }
 } # end

Src/Public/Invoke-AsBuiltReport.Microsoft.Windows.ps1

@@ -85,7 +85,7 @@ function Invoke-AsBuiltReport.Microsoft.Windows {
     #region foreach loop
     foreach ($System in $Target) {
 
-        if (Select-String -InputObject $System -Pattern "^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$") {
+        if (Select-String -InputObject $System -Pattern "^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$" -Quiet) {
             throw "Please use the Fully Qualified Domain Name (FQDN) instead of an IP address when connecting to the System: $System"
         }