Initial commit

Author: nedimf

Makefile

@@ -6,8 +6,8 @@ COMMIT=$(shell git rev-parse --short HEAD 2>/dev/null || echo "none")
 BUILD_TIME=$(shell date -u '+%Y-%m-%d_%H:%M:%S')
 LDFLAGS=-ldflags "-X main.version=$(VERSION) -X main.commit=$(COMMIT)"
 
-# Apple code signing (set via environment or use default)
-APPLE_DEVELOPER_ID ?= 9E5DE6F9BC4DF45371D1121683B21D1638CDB875
+# Apple code signing (set APPLE_DEVELOPER_ID env var to enable)
+# Example: APPLE_DEVELOPER_ID=YOUR_CERT_HASH make build-signed
 
 .PHONY: all build build-signed clean install test lint
 
@@ -18,15 +18,17 @@ build:
 	go build $(LDFLAGS) -o $(BINARY_NAME) .
 
 build-signed: build
-	@echo "Signing binary..."
-	@if [ "$$(uname)" = "Darwin" ]; then \
+	@if [ "$$(uname)" = "Darwin" ] && [ -n "$(APPLE_DEVELOPER_ID)" ]; then \
+		echo "Signing binary..."; \
 		codesign --force --options runtime --sign "$(APPLE_DEVELOPER_ID)" $(BINARY_NAME); \
 		echo "Binary signed successfully"; \
+	elif [ "$$(uname)" = "Darwin" ]; then \
+		echo "Skipping code signing (set APPLE_DEVELOPER_ID to enable)"; \
 	else \
 		echo "Skipping code signing (not macOS)"; \
 	fi
 
-install: build-signed
+install: build
 	@echo "Installing to ~/.local/bin..."
 	@mkdir -p ~/.local/bin
 	@cp $(BINARY_NAME) ~/.local/bin/$(BINARY_NAME)

install.sh

@@ -5,9 +5,9 @@ set -e
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 cd "$SCRIPT_DIR"
 
-# Apple Code Signing Configuration
-# Set these environment variables or they will use defaults
-APPLE_DEVELOPER_ID="${APPLE_DEVELOPER_ID:-9E5DE6F9BC4DF45371D1121683B21D1638CDB875}"
+# Apple Code Signing Configuration (optional)
+# Set APPLE_DEVELOPER_ID environment variable to enable signing
+# Example: export APPLE_DEVELOPER_ID="your-certificate-hash"
 
 echo "=========================================="
 echo "  Logdump Installation Script"
@@ -36,8 +36,8 @@ if ! go build -o logdump .; then
     exit 1
 fi
 
-# Sign the binary (macOS only)
-if [[ "$OSTYPE" == "darwin"* ]]; then
+# Sign the binary (macOS only, requires APPLE_DEVELOPER_ID)
+if [[ "$OSTYPE" == "darwin"* ]] && [[ -n "$APPLE_DEVELOPER_ID" ]]; then
     echo "Signing binary with Developer ID..."
     if command -v codesign &> /dev/null; then
         codesign --force --options runtime --sign "$APPLE_DEVELOPER_ID" logdump
@@ -50,6 +50,8 @@ if [[ "$OSTYPE" == "darwin"* ]]; then
     else
         echo "Warning: codesign not found, skipping signing"
     fi
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    echo "Skipping code signing (set APPLE_DEVELOPER_ID to enable)"
 fi
 
 # Install binary

internal/config/config.go

@@ -91,10 +91,6 @@ func expandPath(path string) string {
 	return path
 }
 
-func findConfigFile() string {
-	return FindConfigFile(false)
-}
-
 // FindConfigFile locates the config file. If globalOnly is true, only checks global config location.
 func FindConfigFile(globalOnly bool) string {
 	var locations []string

internal/logtail/logtail.go

@@ -30,7 +30,6 @@ type Stream struct {
 	Reader     *bufio.Reader
 	LineNumber int
 	Done       chan struct{}
-	mu         sync.RWMutex
 }
 
 type Manager struct {
@@ -61,11 +60,6 @@ func NewManagerWithOptions(tailOnly bool) *Manager {
 }
 
 func (m *Manager) Tail(cfg config.StreamConfig) error {
-	patterns := cfg.Patterns
-	if len(patterns) == 0 {
-		patterns = []string{"*.log"}
-	}
-
 	matches, err := filepath.Glob(filepath.Join(cfg.Path, "*"))
 	if err != nil {
 		return err
@@ -128,7 +122,7 @@ func (m *Manager) watchDirectory(cfg config.StreamConfig) {
 				matches, _ := filepath.Glob(filepath.Join(cfg.Path, "*"))
 				for _, match := range matches {
 					if cfg.Matches(match) {
-						m.addFile(cfg, match)
+						_ = m.addFile(cfg, match)
 					}
 				}
 			}
@@ -144,18 +138,27 @@ func (s *Stream) read(ctx context.Context, entries chan<- LogEntry, tailOnly boo
 
 	// If tailOnly, start at end of file (skip history)
 	if tailOnly {
-		offset, _ = s.File.Seek(0, io.SeekEnd)
+		var err error
+		offset, err = s.File.Seek(0, io.SeekEnd)
+		if err != nil {
+			return
+		}
 	}
 
 	for {
 		select {
 		case <-ctx.Done():
 			return
 		default:
-			fileSize, _ := s.File.Seek(0, io.SeekEnd)
+			fileSize, err := s.File.Seek(0, io.SeekEnd)
+			if err != nil {
+				return
+			}
 
 			if offset < fileSize {
-				s.File.Seek(offset, io.SeekStart)
+				if _, err := s.File.Seek(offset, io.SeekStart); err != nil {
+					return
+				}
 				reader := bufio.NewReader(s.File)
 				for {
 					line, err := reader.ReadString('\n')
@@ -185,7 +188,11 @@ func (s *Stream) read(ctx context.Context, entries chan<- LogEntry, tailOnly boo
 						}(entry)
 					}
 				}
-				offset, _ = s.File.Seek(0, io.SeekCurrent)
+				newOffset, err := s.File.Seek(0, io.SeekCurrent)
+				if err != nil {
+					return
+				}
+				offset = newOffset
 			}
 		}
 

internal/mcp/mcp.go

@@ -109,7 +109,7 @@ func NewServer(manager *logtail.Manager, cfg *config.Config) *Server {
 	// Open MCP activity log file
 	home, _ := os.UserHomeDir()
 	logDir := filepath.Join(home, ".local", "share", "logdump", "logs")
-	os.MkdirAll(logDir, 0755)
+	_ = os.MkdirAll(logDir, 0755)
 
 	logFile, err := os.OpenFile(
 		filepath.Join(logDir, "mcp-activity.log"),
@@ -141,8 +141,8 @@ func (s *Server) logActivity(message string) {
 	}
 
 	line := fmt.Sprintf("[%s] [AGENT: %s] %s\n", timestamp, agent, message)
-	s.logFile.WriteString(line)
-	s.logFile.Sync()
+	_, _ = s.logFile.WriteString(line)
+	_ = s.logFile.Sync()
 }
 
 func (s *Server) logToolCall(toolName string, args map[string]interface{}, resultCount int) {
@@ -166,8 +166,8 @@ func (s *Server) logToolCall(toolName string, args map[string]interface{}, resul
 	}
 
 	line := fmt.Sprintf("[%s] [AGENT: %s] TOOL: %s(args: %s)%s\n", timestamp, agent, toolName, string(argsJSON), resultInfo)
-	s.logFile.WriteString(line)
-	s.logFile.Sync()
+	_, _ = s.logFile.WriteString(line)
+	_ = s.logFile.Sync()
 }
 
 func (s *Server) RunStdio(ctx context.Context) error {
@@ -195,7 +195,7 @@ func (s *Server) handleStdio(ctx context.Context, in io.Reader, out io.Writer) e
 
 			var req MCPRequest
 			if data, err := json.Marshal(rawReq); err == nil {
-				json.Unmarshal(data, &req)
+				_ = json.Unmarshal(data, &req)
 			}
 
 			if req.JSONRPC == "" {
@@ -255,7 +255,7 @@ func (s *Server) handleWebSocket(w http.ResponseWriter, r *http.Request) {
 
 		var req MCPRequest
 		if data, err := json.Marshal(rawReq); err == nil {
-			json.Unmarshal(data, &req)
+			_ = json.Unmarshal(data, &req)
 		}
 
 		if req.JSONRPC == "" {
@@ -965,7 +965,6 @@ func (s *Server) handleResourcesRead(ctx context.Context, req MCPRequest, id int
 
 	uri := params.URI
 	var text string
-	var mimeType string = "text/plain"
 
 	if strings.HasPrefix(uri, "logdump://stream/") {
 		streamName := strings.TrimPrefix(uri, "logdump://stream/")
@@ -975,7 +974,6 @@ func (s *Server) handleResourcesRead(ctx context.Context, req MCPRequest, id int
 			lines = append(lines, fmt.Sprintf("[%s] %s | %s", e.Timestamp.Format("15:04:05.000"), e.Source, e.Content))
 		}
 		text = strings.Join(lines, "\n")
-		mimeType = "text/plain"
 	} else if strings.HasPrefix(uri, "logdump://group/") {
 		groupName := strings.TrimPrefix(uri, "logdump://group/")
 		s.groupsMu.RLock()
@@ -994,7 +992,6 @@ func (s *Server) handleResourcesRead(ctx context.Context, req MCPRequest, id int
 				}
 			}
 			text = strings.Join(lines, "\n")
-			mimeType = "text/plain"
 		} else {
 			return MCPResponse{
 				Error: &MCPError{
@@ -1019,7 +1016,7 @@ func (s *Server) handleResourcesRead(ctx context.Context, req MCPRequest, id int
 			"contents": []map[string]interface{}{
 				{
 					"uri":      params.URI,
-					"mimeType": mimeType,
+					"mimeType": "text/plain",
 					"text":     text,
 				},
 			},