🐛 Fix item display translation issue

SnaveSutit · gitbutler-client · commit 30f0ed689daa · 2026-06-29T08:44:28.000-04:00
diff --git a/src/systems/minecraft/itemModelManager.ts b/src/systems/minecraft/itemModelManager.ts
@@ -96,18 +96,18 @@ export function applyModelDisplayTransform(
 		const rot = display.rotation.map((n: number) => (n * Math.PI) / 180)
 		matrix.makeRotationFromEuler(Reusable.euler1.set(-rot[0], -rot[1], rot[2]))
 	}
+	if (display.scale) {
+		matrix.scale(Reusable.vec2.set(...display.scale))
+	}
 	if (display.translation) {
 		matrix.setPosition(
 			Reusable.vec1.set(
 				display.translation[0],
 				display.translation[1],
-				display.translation[2]
+				-display.translation[2]
 			)
 		)
 	}
-	if (display.scale) {
-		matrix.scale(Reusable.vec2.set(...display.scale))
-	}
 
 	itemModel.boundingBox.applyMatrix4(matrix)
 	itemModel.outline.geometry.applyMatrix4(matrix)

Original file line number	Diff line number	Diff line change
`@@ -96,18 +96,18 @@ export function applyModelDisplayTransform(`
`96`	`96`	`const rot = display.rotation.map((n: number) => (n * Math.PI) / 180)`
`97`	`97`	`matrix.makeRotationFromEuler(Reusable.euler1.set(-rot[0], -rot[1], rot[2]))`
`98`	`98`	`}`
	`99`	`+ if (display.scale) {`
	`100`	`+ matrix.scale(Reusable.vec2.set(...display.scale))`
	`101`	`+ }`
`99`	`102`	`if (display.translation) {`
`100`	`103`	`matrix.setPosition(`
`101`	`104`	`Reusable.vec1.set(`
`102`	`105`	`display.translation[0],`
`103`	`106`	`display.translation[1],`
`104`		`- display.translation[2]`
	`107`	`+ -display.translation[2]`
`105`	`108`	`)`
`106`	`109`	`)`
`107`	`110`	`}`
`108`		`- if (display.scale) {`
`109`		`- matrix.scale(Reusable.vec2.set(...display.scale))`
`110`		`- }`
`111`	`111`
`112`	`112`	`itemModel.boundingBox.applyMatrix4(matrix)`
`113`	`113`	`itemModel.outline.geometry.applyMatrix4(matrix)`