Skip to content

feat: Support lists in expressions#4214

Draft
TomasEng wants to merge 1 commit into
mainfrom
support-lists-in-expressions
Draft

feat: Support lists in expressions#4214
TomasEng wants to merge 1 commit into
mainfrom
support-lists-in-expressions

Conversation

@TomasEng
Copy link
Copy Markdown
Contributor

@TomasEng TomasEng commented May 18, 2026

Description

This pull request adds list support to our expression language in frontend. This includes the following:

  • A list function that creates a list
  • Recognising arrays as valid types
  • Allowing the dataModel function to return a list

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
  • Automated tests
    • Unit test(s) have been added/updated
  • UU/WCAG (follow these guidelines until we have our own)
    • No testing done/necessary (no DOM/visual changes)
  • User documentation @ altinn-studio-docs
  • Support in Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@TomasEng has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 22 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19be23cc-1e32-4d6b-8402-2202e597e478

📥 Commits

Reviewing files that changed from the base of the PR and between 589669d and 2bcb9be.

📒 Files selected for processing (9)
  • schemas/json/layout/expression.schema.v1.json
  • src/codegen/dataTypes/GenerateExpressionOr.ts
  • src/features/expressions/expression-functions.ts
  • src/features/expressions/index.ts
  • src/features/expressions/shared-tests/functions/dataModel/array-is-null.json
  • src/features/expressions/shared-tests/functions/dataModel/lookup-list.json
  • src/features/expressions/shared-tests/functions/list/list.json
  • src/features/expressions/types.ts
  • src/features/expressions/validation.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch support-lists-in-expressions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TomasEng TomasEng force-pushed the support-lists-in-expressions branch from 4453b7c to 2bcb9be Compare May 18, 2026 12:43
@sonarqubecloud
Copy link
Copy Markdown

@TomasEng TomasEng linked an issue May 19, 2026 that may be closed by this pull request
4 tasks
@TomasEng TomasEng moved this to 👷 In progress in Team Altinn Studio May 19, 2026
@TomasEng TomasEng added area/logic related to logic/dynamics/expressions squad/data Issues that belongs to the named squad. kind/product-feature Pull requests containing new features backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels May 19, 2026
@TomasEng
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TomasEng TomasEng marked this pull request as ready for review May 19, 2026 12:23
@TomasEng TomasEng moved this from 👷 In progress to 🔎 In review in Team Altinn Studio May 19, 2026
@TomasEng TomasEng marked this pull request as draft May 21, 2026 08:49
@TomasEng TomasEng moved this from 🔎 In review to 👷 In progress in Team Altinn Studio May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logic related to logic/dynamics/expressions backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features squad/data Issues that belongs to the named squad.

Projects

Status: 👷 In progress

Development

Successfully merging this pull request may close these issues.

Support lists in expressions

1 participant