address comments

Author: arthurpassos

src/Storages/MergeTree/ExportPartTask.cpp

@@ -137,7 +137,7 @@ bool ExportPartTask::executeStep()
             }
         }
 
-        LOG_INFO(getLogger("ExportPartTask"), "Export part {} failed: {}", manifest.data_part->name, e.message());
+        LOG_WARNING(getLogger("ExportPartTask"), "Export part {} failed: {}", manifest.data_part->name, e.message());
 
         ProfileEvents::increment(ProfileEvents::PartsExportFailures);
 

src/Storages/MergeTree/ExportPartitionManifestUpdatingTask.cpp

@@ -401,7 +401,7 @@ std::vector<ReplicatedPartitionExportInfo> ExportPartitionManifestUpdatingTask::
             {
                 if (!count_str.empty())
                 {
-                    exception_count += std::stoull(count_str);
+                    exception_count += parse<size_t>(count_str);
                 }
                 if (last_exception.empty() && !exception_str.empty() && !part_str.empty())
                 {
@@ -478,10 +478,11 @@ void ExportPartitionManifestUpdatingTask::poll()
         LOG_INFO(storage.log, "ExportPartition Manifest Updating Task: Cleanup lock acquired, will remove stale entries");
     }
 
-    Coordination::Stat stat;
-    const auto children = zk->getChildrenWatch(exports_path, &stat, storage.export_merge_tree_partition_watch_callback);
     ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperRequests);
     ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperGetChildrenWatch);
+
+    Coordination::Stat stat;
+    const auto children = zk->getChildrenWatch(exports_path, &stat, storage.export_merge_tree_partition_watch_callback);
     const std::unordered_set<std::string> zk_children(children.begin(), children.end());
 
     const auto now = time(nullptr);

src/Storages/MergeTree/ExportPartitionTaskScheduler.cpp

@@ -74,7 +74,7 @@ void ExportPartitionTaskScheduler::run()
     std::size_t scheduled_exports_count = 0;
 
     const uint32_t seed = uint32_t(std::hash<std::string>{}(storage.replica_name)) ^ uint32_t(scheduled_exports_count);
-    std::mt19937 rng(seed);
+    pcg64_fast rng(seed);
 
     std::lock_guard lock(storage.export_merge_tree_partition_mutex);
 
@@ -261,6 +261,8 @@ void ExportPartitionTaskScheduler::run()
                 catch (const Exception &)
                 {
                     tryLogCurrentException(__PRETTY_FUNCTION__);
+                    ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperRequests);
+                    ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperRemove);
                     zk->tryRemove(fs::path(storage.zookeeper_path) / "exports" / key / "locks" / zk_part_name);
                     /// we should not increment retry_count because the node might just be full
                 }
@@ -417,7 +419,7 @@ void ExportPartitionTaskScheduler::handlePartExportFailure(
         zk->tryGet(count_path, num_exceptions_string);
         ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperRequests);
         ProfileEvents::increment(ProfileEvents::ExportPartitionZooKeeperGet);
-        num_exceptions = std::stoull(num_exceptions_string.c_str());
+        num_exceptions = parse<size_t>(num_exceptions_string);
 
         ops.emplace_back(zkutil::makeSetRequest(last_exception_path / "part", part_name, -1));
         ops.emplace_back(zkutil::makeSetRequest(last_exception_path / "exception", exception->message(), -1));