Skip to content

Commit 88f2258

Browse files
committed
Include review comments.
Signed-off-by: Alexander Adam <alphaone23@gmail.com>
1 parent cd830a5 commit 88f2258

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,9 @@ Docker Usage
281281
docker run -p 8080:8080 ghcr.io/alphaone1/sonicweb:v1.6.0
282282
```
283283

284-
and it will show this documentation. The entrypoint of the dockerfile just starts *SonicWeb* without any parameters.
285-
So `/www` is the default web root directory. Every parameter passed after the image name is appended as a parameter
286-
to *SonicWeb*. For example, running
284+
and it will show this documentation. The entrypoint of the Dockerfile just starts *SonicWeb* without any parameters.
285+
Therefore, `/www` is the default web root directory. Every parameter passed after the image name is appended as a
286+
parameter to *SonicWeb*. For example, running
287287

288288
```sh
289289
docker run -p 8080:8080 ghcr.io/alphaone1/sonicweb:v1.6.0 --log=debug
@@ -296,15 +296,15 @@ is equivalent to running:
296296
```
297297

298298
The docker image is prepared to have new web content mounted on `/www` replacing the default content entirely. A new
299-
web root directory, e.g., `myapp/` could be mounted like this:
299+
web root directory, e.g., `myapp/`, can be mounted like this:
300300

301301
```sh
302302
docker run -p 8080:8080 -v ./myapp:/www:ro ghcr.io/alphaone1/sonicweb:v1.6.0
303303
```
304304

305305
Note that without specifying the `:ro` flag, the content will be mounted as read-write. *SonicWeb* does not write into
306-
the mounted directory. Nevertheless, it poses a potential risk. Also take care that the content of the mounts is
307-
readable by the non-root user that *SonicWeb* uses (UID 65532).
306+
the mounted directory. Nevertheless, it poses a potential risk. Ensure that the mounted content is readable by the
307+
non-root user that *SonicWeb* uses (UID 65532).
308308

309309
If telemetry is needed, port 8081 needs to be exposed additionally:
310310

0 commit comments

Comments
 (0)