GLO: Make MTC reductor configurable

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

Author: f3sch

Modules/GLO/glo-itstpc-mtch-qcmn-test.json

@@ -145,7 +145,7 @@
           }
         ]
       },
-      "MTCTrend": {
+      "MTCTrend1": {
         "active": "true",
         "className": "o2::quality_control::postprocessing::TrendingTask",
         "moduleName": "QcGLO",
@@ -168,14 +168,65 @@
               "mFractionITSTPCmatch_ITS_Hist"
             ],
             "reductorName": "o2::quality_control_modules::glo::MTCReductor",
+            "reductorParameters": {
+              "default": {
+                "default": {
+                  "pt": "1.5"
+                }
+              }
+            },
             "moduleName": "QcGLO"
           }
         ],
         "plots": [
           {
-            "name": "glo_mtc_pt_trending",
+            "name": "glo_mtc_pt15_trending",
             "title": "MTC at #it{p}_{T}=1.5 trending",
-            "varexp": "mFractionITSTPCmatch_ITS_Hist.pt:time",
+            "varexp": "mFractionITSTPCmatch_ITS_Hist.mtc:time",
+            "option": "*L",
+            "graphYRange": "0:1.02",
+            "graphAxisLabel": "MTC:time"
+          }
+        ]
+      },
+      "MTCTrend2": {
+        "active": "true",
+        "className": "o2::quality_control::postprocessing::TrendingTask",
+        "moduleName": "QcGLO",
+        "detectorName": "GLO",
+        "resumeTrend": "false",
+        "initTrigger": [
+          "once"
+        ],
+        "updateTrigger": [
+          "newobject:qcdb:GLO/MO/ITSTPCMatchingTask/mFractionITSTPCmatch_ITS_Hist"
+        ],
+        "stopTrigger": [
+          "usercontrol"
+        ],
+        "dataSources": [
+          {
+            "type": "repository",
+            "path": "GLO/MO/ITSTPCMatchingTask",
+            "names": [
+              "mFractionITSTPCmatch_ITS_Hist"
+            ],
+            "reductorName": "o2::quality_control_modules::glo::MTCReductor",
+            "reductorParameters": {
+              "default": {
+                "default": {
+                  "pt": "0.5"
+                }
+              }
+            },
+            "moduleName": "QcGLO"
+          }
+        ],
+        "plots": [
+          {
+            "name": "glo_mtc_pt05_trending",
+            "title": "MTC at #it{p}_{T}=0.5 trending",
+            "varexp": "mFractionITSTPCmatch_ITS_Hist.mtc:time",
             "option": "*L",
             "graphYRange": "0:1.02",
             "graphAxisLabel": "MTC:time"

Modules/GLO/include/GLO/Reductors.h

@@ -35,13 +35,15 @@ class K0sFitReductor final : public quality_control::postprocessing::ReductorTOb
 class MTCReductor final : public quality_control::postprocessing::ReductorTObject
 {
   void* getBranchAddress() final { return &mStats; };
-  const char* getBranchLeafList() final { return "pt/F"; };
+  const char* getBranchLeafList() final;
   void update(TObject* obj) final;
 
  private:
   struct {
-    Float_t pt{ 0. };
+    Float_t mtc{ 0. };
   } mStats;
+
+  Float_t mPt{ 0 };
 };
 
 class PVITSReductor final : public quality_control::postprocessing::ReductorTObject
@@ -56,7 +58,7 @@ class PVITSReductor final : public quality_control::postprocessing::ReductorTObj
     Float_t pol1{ 0. };
   } mStats;
 
-  Double_t mR0{ 0 }, mR1{ 0 };
+  Float_t mR0{ 0 }, mR1{ 0 };
 };
 
 } // namespace o2::quality_control_modules::glo

Modules/GLO/src/Reductors.cxx

@@ -34,20 +34,27 @@ void K0sFitReductor::update(TObject* obj)
   mStats.sigma = f->GetParameter(helpers::K0sFitter::Parameters::Sigma);
 }
 
+const char* MTCReductor::getBranchLeafList()
+{
+  mPt = common::internal::stringToType<Float_t>(mCustomParameters.atOrDefaultValue("pt", "0"));
+
+  return "mtc/F";
+};
+
 void MTCReductor::update(TObject* obj)
 {
   auto h = dynamic_cast<TH1*>(obj);
   if (!h) {
     return;
   }
 
-  mStats.pt = (float)h->GetBinContent(h->FindBin(1.5));
+  mStats.mtc = (float)h->GetBinContent(h->FindBin(mPt));
 }
 
 const char* PVITSReductor::getBranchLeafList()
 {
-  mR0 = common::internal::stringToType<Double_t>(mCustomParameters.atOrDefaultValue("r0", "0"));
-  mR1 = common::internal::stringToType<Double_t>(mCustomParameters.atOrDefaultValue("r1", "0"));
+  mR0 = common::internal::stringToType<Float_t>(mCustomParameters.atOrDefaultValue("r0", "0"));
+  mR1 = common::internal::stringToType<Float_t>(mCustomParameters.atOrDefaultValue("r1", "0"));
 
   return "pol0/F:pol1/F";
 };
@@ -60,7 +67,6 @@ void PVITSReductor::update(TObject* obj)
   }
 
   auto res = p->Fit("pol1", "QSNC", "", mR0, mR1);
-  printf("Fitting from %f to %f -> %d\n", mR0, mR1, (int)res);
   if ((Int_t)res != 0) {
     return;
   }