Remove CheckInterface::getAcceptedType and isObjectCheckable methods from framework and all user code

Co-authored-by: knopers8 <14327588+knopers8@users.noreply.github.com>

Author: Copilot

Framework/include/QualityControl/CheckInterface.h

@@ -69,16 +69,7 @@ class CheckInterface : public core::UserCodeInterface
   /// then this should be reset here.
   virtual void reset(); // not fully abstract because we don't want to change all the existing subclasses
 
-  /// \brief Returns the name of the class that can be treated by this check.
-  ///
-  /// The name of the class returned by this method will be checked against the MonitorObject's encapsulated
-  /// object's class. If it is the same or a parent then the check will be applied. Therefore, this method
-  /// must return the highest class in the hierarchy that this check can use.
-  /// If the class does not override it, we return "TObject".
-  virtual std::string getAcceptedType();
-
-  bool isObjectCheckable(const std::shared_ptr<core::MonitorObject> mo);
-  bool isObjectCheckable(const core::MonitorObject* mo);
+
 
   virtual void startOfActivity(const core::Activity& activity); // not fully abstract because we don't want to change all the existing subclasses
   virtual void endOfActivity(const core::Activity& activity);   // not fully abstract because we don't want to change all the existing subclasses

Framework/src/CheckInterface.cxx

@@ -18,27 +18,13 @@
 #include "QualityControl/ReferenceUtils.h"
 #include "QualityControl/MonitorObject.h"
 
-#include <TClass.h>
-
 using namespace std;
 using namespace o2::quality_control::core;
 
 namespace o2::quality_control::checker
 {
 
-std::string CheckInterface::getAcceptedType() { return "TObject"; }
-
-bool CheckInterface::isObjectCheckable(const std::shared_ptr<MonitorObject> mo)
-{
-  return isObjectCheckable(mo.get());
-}
 
-bool CheckInterface::isObjectCheckable(const MonitorObject* mo)
-{
-  TObject* encapsulated = mo->getObject();
-
-  return encapsulated->IsA()->InheritsFrom(getAcceptedType().c_str());
-}
 
 void CheckInterface::configure()
 {

Framework/test/testCheckInterface.cxx

@@ -62,10 +62,7 @@ class TestCheck : public checker::CheckInterface
     str->String().Append(" is beautiful now");
   }
 
-  std::string getAcceptedType() override
-  {
-    return "TObjString";
-  }
+
 
   string mValidString;
 };
@@ -91,5 +88,5 @@ TEST_CASE("test_invoke_all_interface_methods")
   testCheck.beautify(mo);
   CHECK(reinterpret_cast<TObjString*>(mo->getObject())->String() == "A string is beautiful now");
 
-  CHECK(testCheck.getAcceptedType() == "TObjString");
+
 }

Modules/Benchmark/include/Benchmark/AlwaysGoodCheck.h

@@ -36,10 +36,7 @@ class AlwaysGoodCheck : public o2::quality_control::checker::CheckInterface
   // Override interface
   void configure() override;
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
-  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  std::string getAcceptedType() override;
-
-  ClassDefOverride(AlwaysGoodCheck, 2);
+  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;  ClassDefOverride(AlwaysGoodCheck, 2);
 };
 
 } // namespace o2::quality_control_modules::benchmark

Modules/Benchmark/src/AlwaysGoodCheck.cxx

@@ -33,7 +33,7 @@ Quality AlwaysGoodCheck::check(std::map<std::string, std::shared_ptr<MonitorObje
   return Quality::Good;
 }
 
-std::string AlwaysGoodCheck::getAcceptedType() { return ""; }
+
 
 void AlwaysGoodCheck::beautify(std::shared_ptr<MonitorObject>, Quality)
 {

Modules/CPV/include/CPV/PedestalCheck.h

@@ -36,10 +36,7 @@ class PedestalCheck : public o2::quality_control::checker::CheckInterface
   // Override interface
   void configure() override;
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
-  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  std::string getAcceptedType() override;
-
- private:
+  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override; private:
   int getRunNumberFromMO(std::shared_ptr<MonitorObject> mo);
 
   // configurable parameters and their default values

Modules/CPV/include/CPV/PhysicsCheck.h

@@ -37,7 +37,7 @@ class PhysicsCheck : public o2::quality_control::checker::CheckInterface
   void configure() override;
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  std::string getAcceptedType() override { return "TH1"; }
+
 
  private:
   int getRunNumberFromMO(std::shared_ptr<MonitorObject> mo);

Modules/CPV/src/PedestalCheck.cxx

@@ -279,8 +279,8 @@ Quality PedestalCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
   return result;
 }
 
-// std::string PedestalCheck::getAcceptedType() { return "TObject"; }
-std::string PedestalCheck::getAcceptedType() { return "TH1"; }
+// 
+
 
 void PedestalCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {

Modules/CTP/include/CTP/RawDataReaderCheck.h

@@ -41,9 +41,7 @@ class RawDataReaderCheck : public o2::quality_control::checker::CheckInterface
   // Override interface
   void configure() override;
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
-  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  std::string getAcceptedType() override;
-  void startOfActivity(const Activity& activity) override;
+  void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;  void startOfActivity(const Activity& activity) override;
   const double_t nofOrbitsPerTF = o2::base::GRPGeomHelper::instance().getNHBFPerTF();
   const double_t TimeTF = nofOrbitsPerTF * o2::constants::lhc::LHCOrbitMUS / 1e6; // in seconds
 

Modules/CTP/src/RawDataReaderCheck.cxx

@@ -201,7 +201,7 @@ float RawDataReaderCheck::setTextPosition(float iPos, std::shared_ptr<TLatex> ms
   return MessagePos;
 }
 
-std::string RawDataReaderCheck::getAcceptedType() { return "TH1"; }
+
 
 void RawDataReaderCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {