Address review comments: Add encapsulatedInheritFrom method and fix cosmetic issues

Co-authored-by: knopers8 <14327588+knopers8@users.noreply.github.com>

Author: Copilot

Framework/include/QualityControl/MonitorObject.h

@@ -117,6 +117,11 @@ class MonitorObject : public TObject
   /// \brief Get metadata value of given key, returns std::nullopt if none exists;
   std::optional<std::string> getMetadata(const std::string& key);
 
+  /// \brief Check if the encapsulated object inherits from the given class name
+  /// \param className Name of the class to check inheritance from
+  /// \return true if the encapsulated object inherits from the given class, false otherwise
+  bool encapsulatedInheritFrom(std::string_view className) const;
+
   void Draw(Option_t* option) override;
   TObject* DrawClone(Option_t* option) const override;
 

Framework/src/MonitorObject.cxx

@@ -162,6 +162,14 @@ std::optional<std::string> MonitorObject::getMetadata(const std::string& key)
   return std::nullopt;
 }
 
+bool MonitorObject::encapsulatedInheritFrom(std::string_view className) const
+{
+  if (!mObject) {
+    return false;
+  }
+  return mObject->IsA()->InheritsFrom(className.data());
+}
+
 std::string MonitorObject::getPath() const
 {
   return RepoPathUtils::getMoPath(this);

Modules/CPV/src/PedestalCheck.cxx

@@ -279,8 +279,6 @@ Quality PedestalCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
   return result;
 }
 
-//
-
 void PedestalCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   return;                                // do noting for the time being. Maybe in the future we will do something sofisticated

Modules/Common/src/MeanIsAbove.cxx

@@ -55,7 +55,14 @@ Quality MeanIsAbove::check(std::map<std::string, std::shared_ptr<MonitorObject>>
 void MeanIsAbove::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   // A line is drawn at the level of the threshold.
-  // Its colour depends on the quality.auto* th1 = dynamic_cast<TH1*>(mo->getObject());
+  // Its colour depends on the quality.
+
+  if (!mo->encapsulatedInheritFrom("TH1")) {
+    ILOG(Error, Support) << "object not checkable" << ENDM;
+    return;
+  }
+
+  auto* th1 = dynamic_cast<TH1*>(mo->getObject());
 
   Double_t xMin = th1->GetXaxis()->GetXmin();
   Double_t xMax = th1->GetXaxis()->GetXmax();

Modules/EMCAL/include/EMCAL/NumPhysTriggCheck.h

@@ -46,8 +46,7 @@ class NumPhysTriggCheck : public o2::quality_control::checker::CheckInterface
   /// \param checkResult Quality status of this checker
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
 
-  /// \brief Accept only TH1 histograms as input
-  /// \return Name of the accepted object: TH1  ClassDefOverride(NumPhysTriggCheck, 1);
+  ClassDefOverride(NumPhysTriggCheck, 1);
 
  private:
   double mFracToMaxGood = 0.5; ///< Thresholds for minimum fraction of physics triggers compared to maximum

Modules/EMCAL/include/EMCAL/RawErrorCheck.h

@@ -56,8 +56,7 @@ class RawErrorCheck : public o2::quality_control::checker::CheckInterface
   /// \param checkResult Quality status of this checker
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
 
-  /// \brief Accept only TH2 histograms as input
-  /// \return Name of the accepted object: TH2  ClassDefOverride(RawErrorCheck, 2);
+  ClassDefOverride(RawErrorCheck, 2);
 
  private:
   /// \brief Decode key of a configurable parameter as boolean

Modules/HMPID/include/HMPID/HmpidRawChecks.h

@@ -48,7 +48,8 @@ class HmpidRawChecks : public o2::quality_control::checker::CheckInterface
   void configure() override;
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  // private:
+
+ private:
   std::array<Quality, 14> check_hHmpBigMap(TProfile2D* h); // <-- Dimensione da chiarire
   std::array<Quality, 42> check_hHmpHvSectorQ(TH2F* h);
   std::array<Quality, 14> check_hHmpPadOccPrf(TProfile* h);

Modules/TOF/src/CheckHitMap.cxx

@@ -49,6 +49,10 @@ Quality CheckHitMap::check(std::map<std::string, std::shared_ptr<MonitorObject>>
   Quality result = Quality::Null;
 
   for (auto& [moName, mo] : *moMap) {
+    if (!mo->encapsulatedInheritFrom("TH2F")) {
+      ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type TH2F" << ENDM;
+      continue;
+    }
     ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM;
     const auto* h = static_cast<TH2F*>(mo->getObject());
     if (h->GetEntries() == 0) { // Histogram is empty
@@ -128,6 +132,10 @@ Quality CheckHitMap::check(std::map<std::string, std::shared_ptr<MonitorObject>>
 void CheckHitMap::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM;
+  if (!mo->encapsulatedInheritFrom("TH2F")) {
+    ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type TH2F" << ENDM;
+    return;
+  }
   if (1) {
     auto* h = static_cast<TH2F*>(mo->getObject());
     if (checkResult != Quality::Good) {

Modules/TOF/src/CheckNoise.cxx

@@ -36,6 +36,10 @@ Quality CheckNoise::check(std::map<std::string, std::shared_ptr<MonitorObject>>*
   Quality result = Quality::Null;
 
   for (auto& [moName, mo] : *moMap) {
+    if (!mo->encapsulatedInheritFrom("TH1F")) {
+      ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type TH1F" << ENDM;
+      continue;
+    }
     if (mo->getName() != mAcceptedName) {
       ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which does not have name " << mAcceptedName << ENDM;
       continue;
@@ -61,6 +65,10 @@ Quality CheckNoise::check(std::map<std::string, std::shared_ptr<MonitorObject>>*
 void CheckNoise::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM;
+  if (!mo->encapsulatedInheritFrom("TH2F")) {
+    ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type TH2F" << ENDM;
+    return;
+  }
   if (mo->getName() == mAcceptedName) {
     auto* h = static_cast<TH2F*>(mo->getObject());
     auto msg = mShifterMessages.MakeMessagePad(h, checkResult);

Modules/TOF/src/CheckRawMultiplicity.cxx

@@ -67,6 +67,10 @@ Quality CheckRawMultiplicity::check(std::map<std::string, std::shared_ptr<Monito
   float hitsIntegral = 0.f;
 
   for (auto& [moName, mo] : *moMap) {
+    if (!mo->encapsulatedInheritFrom("TH1")) {
+      ILOG(Error, Support) << "Cannot check MO " << mo->getName() << " " << moName << " which is not of type TH1" << ENDM;
+      continue;
+    }
     ILOG(Debug, Devel) << "Checking " << mo->getName() << ENDM;
     if (mo->getName() == "Multiplicity/Integrated") {
       const auto* h = static_cast<TH1I*>(mo->getObject());
@@ -151,6 +155,10 @@ Quality CheckRawMultiplicity::check(std::map<std::string, std::shared_ptr<Monito
 void CheckRawMultiplicity::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   ILOG(Debug, Devel) << "Beautifying " << mo->getName() << ENDM;
+  if (!mo->encapsulatedInheritFrom("TH1")) {
+    ILOG(Error, Support) << "Cannot beautify MO " << mo->getName() << " which is not of type TH1" << ENDM;
+    return;
+  }
   if (mo->getName() == "Multiplicity/Integrated") {
     auto* h = static_cast<TH1I*>(mo->getObject());
     auto msg = mShifterMessages.MakeMessagePad(h, checkResult);