[MFT] unified histogram binning with aQC (#2631)

* unify histo binning

* Clang fix

* Revert "unify histo binning"

This reverts commit fa59b90.

* use the Util Tables header for bin definitions

* CLang fix

* try casting as non-const for histo definitions

Author: jjuracka

Modules/MFT/include/MFT/QcMFTUtilTables.h

@@ -15,6 +15,7 @@
 /// \author Guillermo Contreras
 /// \author Katarina Krizkova Gajdosova
 /// \author Diana Maria Krupova
+/// \author Jakub Juracka
 ///
 
 #ifndef QC_MFT_UTIL_TABLES_H
@@ -451,6 +452,41 @@ class QcMFTUtilTables
     { 1, 1, 1, 1, 1, 4, 4, 4, 4, 5, 5, 5, 5, 5, 5, 5, 5, -1, -1, -1, -1 },
     { 1, 1, 1, 1, 1, 4, 4, 4, 4, 5, 5, 5, 5, 5, 5, 5, 5, -1, -1, -1, -1 },
   };
+
+  // bin limits for digits per ROF axis
+  static constexpr float mROFBins[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10,
+                                        11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
+                                        21, 22, 23, 24, 25, 26, 27, 28, 29, 30,
+                                        31, 32, 33, 34, 35, 36, 37, 38, 39, 40,
+                                        41, 42, 43, 44, 45, 46, 47, 48, 49, 50,
+                                        51, 52, 53, 54, 55, 56, 57, 58, 59, 60,
+                                        61, 62, 63, 64, 65, 66, 67, 68, 69, 70,
+                                        71, 72, 73, 74, 75, 76, 77, 78, 79, 80,
+                                        81, 82, 83, 84, 85, 86, 87, 88, 89, 90,
+                                        91, 92, 93, 94, 95, 96, 97, 98, 99, 100,
+                                        110, 120, 130, 140, 150, 160, 170, 180, 190, 200,
+                                        210, 220, 230, 240, 250, 260, 270, 280, 290, 300,
+                                        310, 320, 330, 340, 350, 360, 370, 380, 390, 400,
+                                        410, 420, 430, 440, 450, 460, 470, 480, 490, 500,
+                                        510, 520, 530, 540, 550, 560, 570, 580, 590, 600,
+                                        610, 620, 630, 640, 650, 660, 670, 680, 690, 700,
+                                        710, 720, 730, 740, 750, 760, 770, 780, 790, 800,
+                                        810, 820, 830, 840, 850, 860, 870, 880, 890, 900,
+                                        910, 920, 930, 940, 950, 960, 970, 980, 990, 1000,
+                                        1100, 1200, 1300, 1400, 1500, 1600, 1700, 1800, 1900, 2000,
+                                        2100, 2200, 2300, 2400, 2500, 2600, 2700, 2800, 2900, 3000,
+                                        3100, 3200, 3300, 3400, 3500, 3600, 3700, 3800, 3900, 4000,
+                                        4100, 4200, 4300, 4400, 4500, 4600, 4700, 4800, 4900, 5000,
+                                        5100, 5200, 5300, 5400, 5500, 5600, 5700, 5800, 5900, 6000,
+                                        6100, 6200, 6300, 6400, 6500, 6600, 6700, 6800, 6900, 7000,
+                                        7100, 7200, 7300, 7400, 7500, 7600, 7700, 7800, 7900, 8000,
+                                        8100, 8200, 8300, 8400, 8500, 8600, 8700, 8800, 8900, 9000,
+                                        9100, 9200, 9300, 9400, 9500, 9600, 9700, 9800, 9900, 10000,
+                                        11000, 12000, 13000, 14000, 15000, 16000, 17000, 18000, 19000, 20000,
+                                        21000, 22000, 23000, 24000, 25000, 26000, 27000, 28000, 29000, 30000,
+                                        31000, 32000, 33000, 34000, 35000, 36000, 37000, 38000, 39000, 40000,
+                                        41000, 42000, 43000, 44000, 45000, 46000, 47000, 48000, 49000, 50000 };
+  static constexpr int nROFBins = sizeof(mROFBins) / sizeof(mROFBins[0]) - 1;
 };
 } // namespace o2::quality_control_modules::mft
 

Modules/MFT/src/QcMFTClusterTask.cxx

@@ -16,6 +16,7 @@
 /// \author Katarina Krizkova Gajdosova
 /// \author Diana Maria Krupova
 /// \author David Grund
+/// \author Jakub Juracka
 ///
 
 // C++
@@ -194,7 +195,7 @@ void QcMFTClusterTask::initialize(o2::framework::InitContext& /*ctx*/)
   getObjectsManager()->setDisplayHint(mClusterZ.get(), "hist");
 
   mClustersROFSize = std::make_unique<TH1FRatio>(
-    "mClustersROFSize", "Distribution of the #clusters per ROF; # clusters per ROF; # entries per orbit", maxClusterROFSize, 0, maxClusterROFSize, true);
+    "mClustersROFSize", "Distribution of the #clusters per ROF; # clusters per ROF; # entries per orbit", QcMFTUtilTables::nROFBins, const_cast<float*>(QcMFTUtilTables::mROFBins), true);
   mClustersROFSize->SetStats(0);
   getObjectsManager()->startPublishing(mClustersROFSize.get());
   getObjectsManager()->setDisplayHint(mClustersROFSize.get(), "hist logx logy");
@@ -233,8 +234,8 @@ void QcMFTClusterTask::initialize(o2::framework::InitContext& /*ctx*/)
           getObjectsManager()->startPublishing(mClusterChipOccupancyMap[idx].get());
           getObjectsManager()->setDefaultDrawOptions(mClusterChipOccupancyMap[idx].get(), "colz");
         } // loop over faces
-      }   // loop over disks
-    }     // loop over halfs
+      } // loop over disks
+    } // loop over halfs
 
     // layer histograms
     for (auto nMFTLayer = 0; nMFTLayer < 10; nMFTLayer++) {

Modules/MFT/src/QcMFTDigitTask.cxx

@@ -160,7 +160,7 @@ void QcMFTDigitTask::initialize(o2::framework::InitContext& /*ctx*/)
 
   mDigitsROFSize = std::make_unique<TH1FRatio>("mDigitsROFSize",
                                                "Distribution of the #digits per ROF; # digits per ROF; # entries per orbit",
-                                               maxDigitROFSize, 0, maxDigitROFSize, true);
+                                               QcMFTUtilTables::nROFBins, const_cast<float*>(QcMFTUtilTables::mROFBins), true);
   mDigitsROFSize->SetStats(0);
   getObjectsManager()->startPublishing(mDigitsROFSize.get());
   getObjectsManager()->setDisplayHint(mDigitsROFSize.get(), "hist logx logy");

Modules/MFT/src/QcMFTReadoutTask.cxx

@@ -246,9 +246,9 @@ void QcMFTReadoutTask::monitorData(o2::framework::ProcessingContext& ctx)
             mZoneSummaryChipFault->Fill(xBin, yBin);
           }
         } // end loop over lanes
-      }   // end if is a DDW
-    }     // end if rdh->stop
-  }       // end loop over input
+      } // end if is a DDW
+    } // end if rdh->stop
+  } // end loop over input
 }
 
 void QcMFTReadoutTask::endOfCycle()

Modules/MFT/src/QcMFTTrackTask.cxx

@@ -16,6 +16,7 @@
 /// \author Diana Maria Krupova
 /// \author Katarina Krizkova Gajdosova
 /// \author David Grund
+/// \author Jakub Juracka
 ///
 
 // C++
@@ -37,6 +38,7 @@
 // Quality Control
 #include "QualityControl/QcInfoLogger.h"
 #include "MFT/QcMFTTrackTask.h"
+#include "MFT/QcMFTUtilTables.h"
 #include "Common/TH1Ratio.h"
 #include "Common/TH2Ratio.h"
 #include "DetectorsBase/GRPGeomHelper.h"
@@ -176,7 +178,7 @@ void QcMFTTrackTask::initialize(o2::framework::InitContext& /*ctx*/)
   getObjectsManager()->startPublishing(mTrackTanl.get());
   getObjectsManager()->setDisplayHint(mTrackTanl.get(), "hist");
 
-  mTrackROFNEntries = std::make_unique<TH1FRatio>("mMFTTrackROFSize", "Distribution of the #tracks per ROF; # tracks per ROF; # entries per orbit", MaxTrackROFSize, 0, MaxTrackROFSize, true);
+  mTrackROFNEntries = std::make_unique<TH1FRatio>("mMFTTrackROFSize", "Distribution of the #tracks per ROF; # tracks per ROF; # entries per orbit", QcMFTUtilTables::nROFBins, const_cast<float*>(QcMFTUtilTables::mROFBins), true);
   getObjectsManager()->startPublishing(mTrackROFNEntries.get());
   getObjectsManager()->setDisplayHint(mTrackROFNEntries.get(), "hist logx logy");