Fix O2Linter errors in strangederivedbuilder

Author: romainschotter

PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx

@@ -9,11 +9,15 @@
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
 //
+/// \file strangederivedbuilder.cxx
+/// \brief this task provides general links between collisions and strange objects reconstructed in various ways. 
+/// It is meant to help with providing auxiliary information when dealing with derived data.
+///
+/// \author David Dobrigkeit Chinellato <david.dobrigkeit.chinellato@cern.ch>, Austrian Academy of Sciences & MBI
+/// \author Romain Schotter <romain.schotter@cern.ch>, Austrian Academy of Sciences & MBI
+//
 //__________________________________________________
-// this task provides general links between collisions
-// and strange objects reconstructed in various ways.
-// It is meant to help with providing auxiliary information
-// when dealing with derived data.
+// 
 
 #include "PWGLF/DataModel/EPCalibrationTables.h"
 #include "PWGLF/DataModel/LFParticleIdentification.h"
@@ -1031,8 +1035,8 @@ struct strangederivedbuilder {
 
   void processPureSimulation(aod::McParticles const& mcParticles)
   {
-    for (auto& mcp : mcParticles) {
-      if (TMath::Abs(mcp.y()) < 0.5) {
+    for (auto const& mcp : mcParticles) {
+      if (std::abs(mcp.y()) < 0.5) {
         static_for<0, nSpecies - 1>([&](auto i) {
           constexpr int index = i.value;
           if (mcp.pdgCode() == particlePDGCodes[index] && bitcheck(enabledBits, index)) {
@@ -1049,7 +1053,7 @@ struct strangederivedbuilder {
     // identify best-of collision
     int biggestNContribs = -1;
     float bestCentrality = 100.5;
-    for (auto& collision : collisions) {
+    for (auto const& collision : collisions) {
       if (biggestNContribs < collision.numContrib()) {
         biggestNContribs = collision.numContrib();
         bestCentrality = collision.centFT0C();
@@ -1061,8 +1065,8 @@ struct strangederivedbuilder {
     }
     histos.fill(HIST("h2dNVerticesVsCentrality"), bestCentrality, collisions.size());
 
-    for (auto& mcp : mcParticles) {
-      if (TMath::Abs(mcp.y()) < 0.5 && mcp.isPhysicalPrimary()) {
+    for (auto const& mcp : mcParticles) {
+      if (std::abs(mcp.y()) < 0.5 && mcp.isPhysicalPrimary()) {
         static_for<0, nSpecies - 1>([&](auto i) {
           constexpr int index = i.value;
           if (mcp.pdgCode() == particlePDGCodes[index] && bitcheck(enabledBits, index)) {
@@ -1085,29 +1089,29 @@ struct strangederivedbuilder {
     std::fill(genOmegaPlus.begin(), genOmegaPlus.end(), 0);
 
     // this process function also checks if a given collision was reconstructed and checks explicitly for splitting, etc
-    for (auto& mcCollision : mcCollisions) {
+    for (auto const& mcCollision : mcCollisions) {
       const uint64_t mcCollIndex = mcCollision.globalIndex();
 
       // use one of the generated histograms as the bin finder
       auto hBinFinder = histos.get<TH2>(HIST("h2dGeneratedK0Short"));
 
       auto mcParticles = mcParticlesEntireTable.sliceBy(mcParticlePerMcCollision, mcCollIndex);
-      for (auto& mcp : mcParticles) {
-        if (TMath::Abs(mcp.y()) < 0.5 && mcp.isPhysicalPrimary()) {
+      for (auto const& mcp : mcParticles) {
+        if (std::abs(mcp.y()) < 0.5 && mcp.isPhysicalPrimary()) {
           auto binNumber = hBinFinder->FindBin(mcCollision.bestCollisionCentFT0C(), mcp.pt()); // caution: pack
-          if (mcp.pdgCode() == 310)
+          if (mcp.pdgCode() == PDG_t::kK0Short)
             genK0Short[binNumber]++;
-          if (mcp.pdgCode() == 3122)
+          if (mcp.pdgCode() == PDG_t::kLambda0)
             genLambda[binNumber]++;
-          if (mcp.pdgCode() == -3122)
+          if (mcp.pdgCode() == PDG_t::kLambda0Bar)
             genAntiLambda[binNumber]++;
-          if (mcp.pdgCode() == 3312)
+          if (mcp.pdgCode() == PDG_t::kXiMinus)
             genXiMinus[binNumber]++;
-          if (mcp.pdgCode() == -3312)
+          if (mcp.pdgCode() == PDG_t::kXiPlusBar)
             genXiPlus[binNumber]++;
-          if (mcp.pdgCode() == 3334)
+          if (mcp.pdgCode() == PDG_t::kOmegaMinus)
             genOmegaMinus[binNumber]++;
-          if (mcp.pdgCode() == -3334)
+          if (mcp.pdgCode() == PDG_t::kOmegaPlusBar)
             genOmegaPlus[binNumber]++;
         }
       }