Some error detection during timestamp sampling

Author: sawenzel

MC/bin/o2dpg_sim_workflow_anchored.py

@@ -192,11 +192,14 @@ def determine_timestamp(sor, eor, splitinfo, cycle, ntf):
 
     # ntimeframes is the total number of timeframes possible
     # if we have totaljobs number of jobs
-    timeframesperjob = ntimeframes // totaljobs
+    maxtimeframesperjob = ntimeframes // totaljobs
     orbitsperjob = norbits // totaljobs
-    print (f"Each job can do {timeframesperjob} maximally at a prod split of {totaljobs}")
-    print (f"With each job doing {ntf} timeframes, this corresponds to a filling rate of ", ntf/timeframesperjob)
-    maxcycles = timeframesperjob // ntf
+    print (f"Each job can do {maxtimeframesperjob} maximally at a prod split of {totaljobs}")
+    print (f"With each job doing {ntf} timeframes, this corresponds to a filling rate of ", ntf/maxtimeframesperjob)
+    # filling rate should be smaller than 100%
+    assert(ntf <= maxtimeframesperjob)
+
+    maxcycles = maxtimeframesperjob // ntf
     print (f"We can do this amount of cycle iterations to achieve 100%: ", maxcycles)
 
     return sor, int(thisjobID * maxcycles) + cycle
@@ -213,6 +216,9 @@ def main():
     parser.add_argument('forward', nargs=argparse.REMAINDER) # forward args passed to actual workflow creation
     args = parser.parse_args()
 
+    # split id should not be larger than production id
+    assert(args.split_id < args.prod_split)
+
     # make a CCDB accessor object
     ccdbreader = CCDBAccessor(args.ccdb_url)
     # fetch the EOR/SOR

MC/run/ANCHOR/2021/OCT/pass4/anchorMC.sh

@@ -102,6 +102,7 @@ echo "baseargs: ${baseargs}"
 echo "remainingargs: ${remainingargs}"
 
 ${O2DPG_ROOT}/MC/bin/o2dpg_sim_workflow_anchored.py ${baseargs} -- ${remainingargs} &> timestampsampling.log
+[ "$?" != "0" ] && echo "Problem during anchor timestamp sampling " && exit 1
 
 TIMESTAMP=`grep "Determined timestamp to be" timestampsampling.log | awk '//{print $6}'`
 echo "TIMESTAMP IS ${TIMESTAMP}"