Skip to content

MathUtils.cpp/h: Unused functions / duplicated functionality #2259

@KevinJW

Description

@KevinJW

In MathUtils.cpp there are a number of functions that are apparently not used by the rest of the code:

GetSafeScalarInverse
VecContainsZero
VecContainsOne
GetM44Inverse
GetM44M44Product
GetM44V4Product
GetV4Sum
GetMxbCombine
GetMxbInverse

Should they be used int he code where we are not? or should the code be removed? I'm more concerned with the 4x4 matrix bits as they don't look the most robust numerically, and we have code in MatrixOpData.cpp for a better inverse.

I also note we have a IsNan function that is a simple wrapper for std::isnan do we need it? If we want to keep it we should update the test code the calls std::isnan to use the wrapper.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions