Skip to content

Commit c0aedb8

Browse files
committed
Skip aviftunetest when AOM_TUNE_IQ is unavailable
1 parent 1422eb1 commit c0aedb8

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

tests/gtest/aviftunetest.cc

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,14 @@ TEST(AomTuneMetricTest, GenerateDifferentBitstreams) {
3737
ASSERT_EQ(avifEncoderSetCodecSpecificOption(encoder.get(), "tune", tune),
3838
AVIF_RESULT_OK);
3939
testutil::AvifRwData encoded;
40-
ASSERT_EQ(avifEncoderWrite(encoder.get(), image.get(), &encoded),
41-
AVIF_RESULT_OK);
40+
avifResult result = avifEncoderWrite(encoder.get(), image.get(), &encoded);
41+
if (std::string(tune) == "iq" &&
42+
result == AVIF_RESULT_INVALID_CODEC_SPECIFIC_OPTION) {
43+
// The aom version that libavif was built with likely does not support
44+
// AOM_TUNE_IQ yet.
45+
continue;
46+
}
47+
ASSERT_EQ(result, AVIF_RESULT_OK);
4248
for (const std::vector<uint8_t>& encoded_with_another_tune :
4349
encoded_bitstreams) {
4450
const bool is_same = encoded.size == encoded_with_another_tune.size() &&
@@ -75,15 +81,13 @@ TEST(AomSharpnessTest, GenerateDifferentBitstreams) {
7581
image->height = 64;
7682

7783
std::vector<std::vector<uint8_t>> encoded_bitstreams;
78-
for (bool set_sharpness_to_0 : {false, true}) {
84+
for (const char* sharpness : {"0", "2"}) {
7985
EncoderPtr encoder(avifEncoderCreate());
8086
ASSERT_NE(encoder, nullptr);
8187
encoder->codecChoice = AVIF_CODEC_CHOICE_AOM;
82-
if (set_sharpness_to_0) {
83-
ASSERT_EQ(
84-
avifEncoderSetCodecSpecificOption(encoder.get(), "sharpness", "0"),
85-
AVIF_RESULT_OK);
86-
}
88+
ASSERT_EQ(avifEncoderSetCodecSpecificOption(encoder.get(), "sharpness",
89+
sharpness),
90+
AVIF_RESULT_OK);
8791
testutil::AvifRwData encoded;
8892
ASSERT_EQ(avifEncoderWrite(encoder.get(), image.get(), &encoded),
8993
AVIF_RESULT_OK);

0 commit comments

Comments
 (0)