Skip to content

Commit 263bd9d

Browse files
Merge pull request #3487 from AI-Hypercomputer:pypi_docker_fix
PiperOrigin-RevId: 888770204
2 parents 484ac77 + 6ae8475 commit 263bd9d

1 file changed

Lines changed: 2 additions & 18 deletions

File tree

.github/workflows/build_and_push_docker_image.yml

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ jobs:
5454
runs-on: linux-x86-n2-16-buildkit
5555
container: google/cloud-sdk:524.0.0
5656
if: >
57+
github.event_name == 'release' ||
5758
github.event_name == 'schedule' ||
5859
github.event_name == 'pull_request' ||
5960
github.event_name == 'workflow_dispatch' && (
@@ -86,15 +87,8 @@ jobs:
8687
# This ensures that every job clones the exact same commit as "setup" job
8788
ref: ${{ inputs.maxtext_sha }}
8889

89-
- name: Checkout post-training dependencies
90-
if: steps.check.outputs.should_run == 'true' && inputs.image_name == 'maxtext_post_training_nightly'
91-
run: |
92-
git clone https://github.com/google/tunix.git ./tunix
93-
git clone https://github.com/vllm-project/vllm.git ./vllm
94-
git clone https://github.com/vllm-project/tpu-inference.git ./tpu-inference
95-
9690
- name: Mark git repositories as safe
97-
run: git config --global --add safe.directory '*'
91+
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}
9892
if: steps.check.outputs.should_run == 'true'
9993

10094
- name: Configure Docker
@@ -148,16 +142,6 @@ jobs:
148142
# Add MaxText tag
149143
maxtext_hash=$(git rev-parse --short HEAD)
150144
gcloud container images add-tag "$SOURCE_IMAGE:${{ github.run_id }}" "$SOURCE_IMAGE:maxtext_${maxtext_hash}_${clean_date}" --quiet
151-
152-
# Add post-training dependencies tags
153-
if [ "${{ inputs.workflow }}" == "post-training" ]; then
154-
for dir in tunix vllm tpu-inference; do
155-
if [ -d "./$dir" ]; then
156-
dir_hash=$(git -C "$dir" rev-parse --short HEAD)
157-
gcloud container images add-tag "$SOURCE_IMAGE:${{ github.run_id }}" "$SOURCE_IMAGE:${dir}_${dir_hash}_${clean_date}" --quiet
158-
fi
159-
done
160-
fi
161145
fi
162146
env:
163147
INPUTS_IMAGE_NAME: ${{ inputs.image_name }}

0 commit comments

Comments
 (0)