Added check for incorrect titles (#57)

Author: Seluj78

VERSION

@@ -1 +1 @@
-v1.10.0
+v1.11.0

comment_bodies.json

@@ -16,7 +16,6 @@
   "automerge_donotmerge": [
     "`DO NOT MERGE` ou `automerge` ? Je sais pas quoi faire là !",
     "Décidez-vous les gars, `DO NOT MERGE` ou `automerge` ?"
-
   ],
   "automerge_approved": [
     "Dès que les tests passent, je merge ! Merci @$AUTHOR @$REVIEWERS !",
@@ -34,5 +33,12 @@
   ],
   "greetings": [
     "Hello @$AUTHOR ! Bienvenue dans le monde merveilleux de la traduction de la documentation de Python !\nJe suis PyDocTeur, le robot amical qui s'occupe d'automatiser certaines tâches.\nSi tu as des questions, n'hésite pas à ping @JulienPalard ou @Seluj78"
+  ],
+  "unmergeable": [
+    "Ping @$AUTHOR & @$REVIEWERS !\nIl m'est actuellement impossible de merge cette pull request.\n\nL'état actuel de merge la PR est `@$MERGEABLE_STATE`.\n\nMerci de rebase ou de résoudre les conflits !"
+  ],
+  "incorrect_title":
+  [
+    "Hello @$AUTHOR ! Désolé, mais ton titre de pull request me semble invalide par rapport à ce que je suis programmé d'accepter.\nMerci de le corriger ou d'ajouter le label `meta` si c'est une PR spéciale."
   ]
 }

pydocteur/actions.py

@@ -54,6 +54,7 @@ def replace_body_variables(pr: PullRequest, body: str):
     reviewers_login.discard(author)
     reviewers = ", @".join(reviewers_login)
     new_body = new_body.replace("@$REVIEWERS", "@" + reviewers)
+    new_body = new_body.replace("@$MERGEABLE_STATE", pr.mergeable_state)
     return new_body
 
 
@@ -82,9 +83,17 @@ def merge_and_thank_contributors(pr: PullRequest, state: str):
     contributor_usernames = [u.login for u in repo.get_collaborators()]
     reviewer_usernames = [i.user.login for i in pr.get_reviews()]
     if not any(x in reviewer_usernames for x in contributor_usernames):
-        logging.info("PR not reviewed by a contributor, not merginf.")
+        logging.info("PR not reviewed by a contributor, not merging.")
         return
 
+    logger.info(f"Testing if PR #{pr.number} can be merged")
+    if not pr.mergeable or pr.mergeable_state != "clean":
+        logger.warning(f"PR #{pr.number} cannot be merged. mergeable_state={pr.mergeable_state}")
+        unmergeable_comments = get_comment_bodies("unmergeable")
+        body = random.choice(unmergeable_comments)
+        body = replace_body_variables(pr, body)
+        pr.create_issue_comment(body + END_OF_BODY.format(state=state, version=VERSION))
+        return
     logger.info(f"PR #{pr.number}: About to merge")
     warnings = get_comment_bodies("automerge_approved_testok")
     thanks = get_comment_bodies("automerge_approved_testok-done")
@@ -114,3 +123,11 @@ def maybe_greet_user(pr: PullRequest):
         body = replace_body_variables(pr, body)
         logger.info(f"PR #{pr.number}: Greeting {pr.user.login}")
         pr.create_issue_comment(body + END_OF_BODY.format(state="greetings", version=VERSION))
+
+
+def comment_about_title(pr: PullRequest):
+    bodies = get_comment_bodies("incorrect_title")
+    body = random.choice(bodies)
+    body = replace_body_variables(pr, body)
+    logger.info(f"PR #{pr.number}: Sending incorrect title message")
+    pr.create_issue_comment(body + END_OF_BODY.format(state="incorrect_title", version=VERSION))

pydocteur/app.py

@@ -5,12 +5,14 @@
 from flask import jsonify
 from flask import request
 
+from pydocteur.actions import comment_about_title
 from pydocteur.actions import comment_pr
 from pydocteur.actions import maybe_greet_user
 from pydocteur.actions import merge_and_thank_contributors
 from pydocteur.github_api import get_pull_request
 from pydocteur.github_api import has_pr_number
 from pydocteur.pr_status import get_pr_state
+from pydocteur.pr_status import is_title_ok
 from pydocteur.settings import VERSION
 
 application = Flask(__name__)
@@ -61,6 +63,11 @@ def process_incoming_payload():
         logger.info(f"State of PR #{pr.number} hasn't changed, ignoring. (state: {state})")
         return "OK", 200
 
+    if not is_title_ok(pr):
+        logging.info(f"Title of PR #{pr.number} is incorrect, sending message")
+        comment_about_title(pr)
+        return "OK", 200
+
     state_dict = {
         "automerge_approved_testok": merge_and_thank_contributors,
         # ...

pydocteur/pr_status.py

@@ -1,5 +1,6 @@
 import logging
 import os
+import re
 from itertools import groupby
 
 from pydocteur.github_api import get_graphql_api
@@ -84,6 +85,17 @@ def is_already_greeted(pr):
     return any("(state: greetings)" in my_comment for my_comment in my_comments)
 
 
+def is_title_ok(pr):
+    if is_label_set(pr, "meta"):
+        return True
+    if pr.title.startswith(("traduction de", "Traduction de", "Fix fuzzies in", "Fix fuzzies dans")) or re.findall(
+        r"\\.po", pr.title
+    ):
+        return True
+    else:
+        return False
+
+
 def state_name(**kwargs):
     SIMPLIFICATIONS = {
         "testok": "",