fixes

Author: jp8-isep

backend/models/chat_room.py

@@ -15,7 +15,8 @@ def __init__(self, db):
     def create_chat_room(self, topic_id: Optional[str], name: str, description: str, owner_id: str,
                         is_public: bool = True, tags: Optional[List[str]] = None,
                         picture: Optional[str] = None,
-                        background_picture: Optional[str] = None) -> str:
+                        background_picture: Optional[str] = None,
+                        voip_enabled: bool = True) -> str:
         """Create a new conversation (chat room) in a topic or a group chat."""
         chat_room_data = {
             'topic_id': ObjectId(topic_id) if topic_id else None,  # Conversation belongs to a Topic or None for Group Chat
@@ -27,7 +28,7 @@ def create_chat_room(self, topic_id: Optional[str], name: str, description: str,
             'is_public': is_public,
             'picture': picture,  # Chat room picture (displayed in header/list)
             'background_picture': background_picture,  # Background picture (faded behind messages)
-            'voip_enabled': False,  # VoIP calls disabled by default
+            'voip_enabled': voip_enabled,
             'member_count': 1,  # Owner counts as first member
             'members': [ObjectId(owner_id)],
             'banned_users': [],  # Users banned from this chat

backend/models/friend.py

@@ -138,28 +138,45 @@ def accept_friend_request(self, request_id: str, user_id: str) -> Dict[str, Any]
             'updated_at': datetime.utcnow().isoformat()
         }
 
-    def reject_friend_request(self, request_id: str, user_id: str) -> bool:
+    def reject_friend_request(self, request_id: str, user_id: str) -> Optional[Dict[str, str]]:
         """Reject a friend request."""
-        result = self.collection.delete_one({
+        request = self.collection.find_one({
             '_id': ObjectId(request_id),
             'to_user_id': ObjectId(user_id),
             'status': 'pending'
         })
+        
+        if not request:
+            return None
 
-        return result.deleted_count > 0
+        from_user_id = str(request['from_user_id'])
+        result = self.collection.delete_one({'_id': ObjectId(request_id)})
+
+        if result.deleted_count > 0:
+            return {'from_user_id': from_user_id, 'to_user_id': user_id}
+        return None
 
-    def cancel_friend_request(self, request_id: str, user_id: str) -> bool:
+    def cancel_friend_request(self, request_id: str, user_id: str) -> Optional[Dict[str, str]]:
         """Cancel a sent friend request."""
-        result = self.collection.delete_one({
+        request = self.collection.find_one({
             '_id': ObjectId(request_id),
             'from_user_id': ObjectId(user_id),
             'status': 'pending'
         })
+        
+        if not request:
+            return None
 
-        return result.deleted_count > 0
+        to_user_id = str(request['to_user_id'])
+        result = self.collection.delete_one({'_id': ObjectId(request_id)})
+
+        if result.deleted_count > 0:
+            return {'from_user_id': user_id, 'to_user_id': to_user_id}
+        return None
 
     def remove_friend(self, user_id: str, friend_id: str) -> bool:
         """Remove a friend."""
+        # This one already has the IDs passed in
         result = self.collection.delete_one({
             '$or': [
                 {'from_user_id': ObjectId(user_id), 'to_user_id': ObjectId(friend_id), 'status': 'accepted'},

backend/models/voip.py

@@ -1,6 +1,9 @@
 from datetime import datetime, timedelta
 from typing import List, Dict, Optional, Any
 from bson import ObjectId
+import logging
+
+logger = logging.getLogger(__name__)
 
 
 class VoipCall:
@@ -57,6 +60,7 @@ def create_call(self, room_id: str, room_type: str, created_by: str, room_name:
         result = self.collection.insert_one(call_doc)
         call_doc['id'] = str(result.inserted_id)
         call_doc['_id'] = str(result.inserted_id)
+        logger.info(f"New VOIP call created: {call_doc['id']} in room {room_id} by {created_by}")
         return self._process_call(call_doc)
 
     def get_active_call(self, room_id: str) -> Optional[Dict[str, Any]]:
@@ -124,9 +128,10 @@ def join_call(self, call_id: str, user_id: str) -> Optional[Dict[str, Any]]:
             )
 
             if result.modified_count > 0:
+                logger.info(f"User {user_id} joined VOIP call {call_id}")
                 return self.get_call_by_id(call_id)
         except Exception as e:
-            print(f"Error joining call: {e}")
+            logger.error(f"Error joining call {call_id} for user {user_id}: {e}")
         return None
 
     def leave_call(self, call_id: str, user_id: str) -> Optional[Dict[str, Any]]:
@@ -146,11 +151,12 @@ def leave_call(self, call_id: str, user_id: str) -> Optional[Dict[str, Any]]:
                 call = self.get_call_by_id(call_id)
                 if call and len(call.get('participants', [])) == 0:
                     # End the call
-                    self.end_call(call_id)
+                    logger.info(f"Ending call {call_id} because no participants remain after user {user_id} left")
+                    self.end_call(call_id, 'no_participants')
                     return {'ended': True, 'call_id': call_id}
                 return call
         except Exception as e:
-            print(f"Error leaving call: {e}")
+            logger.error(f"Error leaving call {call_id} for user {user_id}: {e}")
         return None
 
     def end_call(self, call_id: str, reason: str = None) -> bool:
@@ -166,9 +172,11 @@ def end_call(self, call_id: str, reason: str = None) -> bool:
                     }
                 }
             )
+            if result.modified_count > 0:
+                logger.info(f"Call {call_id} ended. Reason: {reason or 'Not specified'}")
             return result.modified_count > 0
         except Exception as e:
-            print(f"Error ending call: {e}")
+            logger.error(f"Error ending call {call_id}: {e}")
         return False
 
     def set_mute_status(self, call_id: str, user_id: str, is_muted: bool) -> bool:
@@ -282,7 +290,8 @@ def check_and_remove_offline_participants(self) -> List[Dict[str, Any]]:
                 # Check if call is now empty
                 updated_call = self.get_call_by_id(call_id)
                 if updated_call and len(updated_call.get('participants', [])) == 0:
-                    self.end_call(call_id, 'no_participants')
+                    logger.info(f"Ending call {call_id} during offline cleanup (no participants remain)")
+                    self.end_call(call_id, 'no_participants_offline')
                     affected.append({
                         'call_id': call_id,
                         'removed_users': removed_users,

backend/routes/chat_rooms.py

@@ -159,6 +159,7 @@ def create_group_chat():
         # Process pictures if provided
         picture = data.get('picture')
         background_picture = data.get('background_picture')
+        voip_enabled = data.get('voip_enabled', True)
 
         from utils.image_compression import compress_image_base64
         from utils.imgbb_upload import process_image_for_storage
@@ -188,7 +189,8 @@ def create_group_chat():
             is_public=False, # Group chats are private by default usually, or invite only
             tags=[],
             picture=picture,
-            background_picture=background_picture
+            background_picture=background_picture,
+            voip_enabled=voip_enabled
         )
 
         # Invite users
@@ -291,6 +293,7 @@ def create_conversation(topic_id):
         description = data.get('description', '').strip()
         is_public = data.get('is_public', True)
         tags = data.get('tags', [])
+        voip_enabled = data.get('voip_enabled', True)
 
         if not name:
             return jsonify({'success': False, 'errors': ['Conversation name is required']}), 400
@@ -340,7 +343,8 @@ def create_conversation(topic_id):
             is_public=is_public,
             tags=tags,
             picture=picture,
-            background_picture=background_picture
+            background_picture=background_picture,
+            voip_enabled=voip_enabled
         )
 
         # Get created chat room

backend/routes/posts.py

@@ -255,6 +255,20 @@ def create_post(topic_id):
         if use_anonymous and topic.get('settings', {}).get('allow_anonymous', True):
             anon_model = AnonymousIdentity(current_app.db)
             anonymous_identity = anon_model.get_anonymous_identity(user_id, topic_id)
+            if not anonymous_identity:
+                # Create a new one if it doesn't exist
+                anonymous_identity = anon_model.create_anonymous_identity(user_id, topic_id)
+                # Emit socket event so Settings page can update
+                try:
+                    from app import socketio
+                    if socketio:
+                        socketio.emit('anonymous_identity_updated', {
+                            'user_id': user_id,
+                            'topic_id': topic_id,
+                            'anonymous_name': anonymous_identity
+                        }, room=f"user_{user_id}")
+                except Exception as e:
+                    logger.warning(f"Failed to emit socket event for auto-created identity: {str(e)}")
 
         # Create post
         post_model = Post(current_app.db)

backend/routes/topics.py

@@ -812,6 +812,20 @@ def update_anonymous_identity(topic_id):
 
         # Get the final identity name
         final_name = anon_model.get_anonymous_identity(user_id, topic_id)
+        
+        # Emit socket event
+        try:
+            from app import socketio
+            if socketio:
+                socketio.emit('anonymous_identity_updated', {
+                    'user_id': user_id,
+                    'topic_id': topic_id,
+                    'anonymous_name': final_name or custom_name
+                }, room=f"user_{user_id}")
+                logger.info(f"Emitted anonymous_identity_updated for user {user_id} in topic {topic_id}")
+        except Exception as e:
+            logger.warning(f"Failed to emit socket event for identity update: {str(e)}")
+
         return jsonify({
             'success': True,
             'message': 'Anonymous identity set successfully',