Normalize party name for display (#292)

* Normalize party name for display

* Don't modify base party

Author: dektar

5calls/app/src/main/java/org/a5calls/android/a5calls/model/Contact.java

@@ -98,14 +98,23 @@ public String getDescription(Resources res) {
             return "";
         }
         if (!TextUtils.isEmpty(party)) {
+            String partyForDisplay = normalizeParty(party);
             if (!TextUtils.isEmpty(district)) {
                 return res.getString(R.string.contact_political_details_all,
-                        name, party, state, district);
+                        name, partyForDisplay, state, district);
             }
             return res.getString(R.string.contact_political_details_party_state,
-                    name, party, state);
+                    name, partyForDisplay, state);
         }
         return res.getString(R.string.contact_political_details_state,
                 name, state);
     }
+
+    // See 5calls-api's utils/party.go.
+    private static String normalizeParty(String party) {
+        if (TextUtils.equals(party, "Democratic")) {
+            return "Democrat";
+        }
+        return party;
+    }
 }

5calls/app/src/test/java/org/a5calls/android/a5calls/FakeJSONData.java

@@ -81,6 +81,14 @@ public void testDescriptionGovernor() {
         assertEquals("Kathy Hochul is a Democrat from NY.", description);
     }
 
+    @Test
+    public void testDescriptionNormalizeParty() {
+        // Party listed as "Democratic" in JSON.
+        List<Contact> contacts = getTestContacts();
+        String description = contacts.get(2).getDescription(getApplicationContext().getResources());
+        assertEquals("Chuck Schumer is a Democrat from NY.", description);
+    }
+
     @Test
     public void testDescriptionMissingFields() {
         Contact contact = TestModelUtils.createContact("contactId", "name");